Skip to content

Conversation

@manojsdoshi
Copy link
Contributor

If merged, this PR will:

close #220
close #257
close #249
close #281
close #252
close #247
close #296
close #300
close #297
close #306
close #292
close #301

ethanlabelle and others added 13 commits November 2, 2022 12:11
* The ledger close time can occasionally be a few seconds in the future,
  which causes ETL to not publish the ledger, because the age
  calculation wraps around and the age is computed as a very large
  unsigned integer. This fix rounds to zero when the age would be
  negative
* Indicate defaults for logging parameters
* Remove log_to_file from example config
* Remove online_delete from example config
* Port book_changes RPC call from rippled
* Refactor for readability and modern cpp
* Implement a probing ETL source and do not require SSL certs for SslETLSource (XRPLF#251)

Fixes XRPLF#251
Copy link
Contributor

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manojsdoshi manojsdoshi merged commit 5a34858 into XRPLF:release Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants