Fixes issue with assigning values to offers objects #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM |
godexsoft
approved these changes
Sep 12, 2022
df0a4c3 to
03765ba
Compare
cjcobb23
previously requested changes
Sep 13, 2022
Contributor
cjcobb23
left a comment
There was a problem hiding this comment.
Remove the merge commit, then this is good to go
f660660 to
bcd8681
Compare
Already addressed merge commit
bcd8681 to
3e63fc6
Compare
manojsdoshi
pushed a commit
to manojsdoshi/clio
that referenced
this pull request
Nov 2, 2022
manojsdoshi
pushed a commit
to manojsdoshi/clio
that referenced
this pull request
Nov 2, 2022
manojsdoshi
pushed a commit
to manojsdoshi/clio
that referenced
this pull request
Nov 2, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with using
nft_buy_offersornft_sell_offerswhen there are actually offers to return. Previously these RPC calls would fail with internal error when building the offer object for the serialized response.