insert delivered_amount based on close time #252
Conversation
| std::shared_ptr<ripple::TxMeta const> const& meta, | ||
| uint32_t date) | ||
| { | ||
| if (canHaveDeliveredAmount(txn, meta)) |
There was a problem hiding this comment.
Do we also need to change canHaveDeliveredAmount?
There was a problem hiding this comment.
Don't think so, that function is just looking at the transaction to see if its the type of transaction that could have a delivered amount.
| if (canHaveDeliveredAmount(txn, meta)) | ||
| { | ||
| if (auto amt = getDeliveredAmount(txn, meta, meta->getLgrSeq())) | ||
| if (auto amt = getDeliveredAmount(txn, meta, meta->getLgrSeq(), date)) |
There was a problem hiding this comment.
Can we do a cpp17 style if statement here?
There was a problem hiding this comment.
Like : if (auto amt = getDeliveredAmount(txn, meta, meta->getLgrSeq(), date); amt)?
There was a problem hiding this comment.
Yes. I like that better, but if you hate it feel free to leave it
| if (ledgerSequence >= 4594095) | ||
| if (ledgerSequence >= 4594095 || date > 446000000) | ||
| { | ||
| return txn->getFieldAmount(ripple::sfAmount); |
There was a problem hiding this comment.
Is it guaranteed that in this case sfAmount will be delivered_amount?
If a transaction is a partial payment, will it always have delivered_amount in the metadata?
There was a problem hiding this comment.
According to the comment (which I copied from rippled), delivered amount will be in the metadata for partial payments after this ledger. The metadata is checked prior to this, at the beginning of the function.
Previously, we were only checking the ledger sequence to determine if we should insert delivered amount. This works on mainnet, but could fail on other networks that are newer
This change is