Fix bug causing some ledgers to not be published #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
We don't publish ledgers that are over 10 minutes old |
* The ledger close time can occasionally be a few seconds in the future, which causes ETL to not publish the ledger, because the age calculation wraps around and the age is computed as a very large unsigned integer. This fix rounds to zero when the age would be negative
70b7a25 to
0ec8de0
Compare
natenichols
approved these changes
Aug 29, 2022
manojsdoshi
pushed a commit
to manojsdoshi/clio
that referenced
this pull request
Nov 2, 2022
* The ledger close time can occasionally be a few seconds in the future, which causes ETL to not publish the ledger, because the age calculation wraps around and the age is computed as a very large unsigned integer. This fix rounds to zero when the age would be negative
manojsdoshi
pushed a commit
to manojsdoshi/clio
that referenced
this pull request
Nov 2, 2022
* The ledger close time can occasionally be a few seconds in the future, which causes ETL to not publish the ledger, because the age calculation wraps around and the age is computed as a very large unsigned integer. This fix rounds to zero when the age would be negative
manojsdoshi
pushed a commit
to manojsdoshi/clio
that referenced
this pull request
Nov 2, 2022
* The ledger close time can occasionally be a few seconds in the future, which causes ETL to not publish the ledger, because the age calculation wraps around and the age is computed as a very large unsigned integer. This fix rounds to zero when the age would be negative
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close time in the ledger header is not accurate to the second. Sometimes, the close time is a second or two in the future, and so the age was being calculated as negative, which converts to a very large unsigned integer. This caused us to skip publishing ledgers.
This change is