Skip to content

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Apr 30, 2019

Fixes #9763

Note: This branch is based on #9764.
Merge instructions

  1. Review and Merge Inflate post list menu item from xml instead of adding it dynamically #9764
  2. Update the target branch to feature/post-filters-compat-view-toggle
  3. Review and Merge this PR

Updates the loading skeleton for the compact view layout type on post list screen.

To test: - you might want to change the network type to EDGE so it takes a while before the items are fetched

  1. Clear app data or switch to a site for which you haven't loaded posts yet
  2. My Site
  3. Blog Posts
  4. Notice loading skeletons are being displayed
  5. Click on the "toggle rows layout" - change it to compact layout
  6. Scroll and observe the compact version of the loading skeleton is being displayed

compact-loading-skeleton

Update release notes:

  • There is no need to update the release-notes as the feature hasn't been released yet

Note - This code was mostly developed by @onepointsixtwo in #9733, but the fork of the repo was deleted before we merged the PR.

Copy link
Contributor

@maxme maxme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: (waiting for an update on #9764 before switching target branch and merging that one)

@maxme maxme changed the base branch from issue/9725-post-list-inflate-xml to feature/post-filters-compat-view-toggle May 2, 2019 14:16
@maxme
Copy link
Contributor

maxme commented May 2, 2019

Review and Merge #9764

Done

Update the target branch to feature/post-filters-compat-view-toggle

Done

Review and Merge this PR

Done

@maxme maxme merged commit 06407d7 into feature/post-filters-compat-view-toggle May 2, 2019
@oguzkocer oguzkocer deleted the issue/9763-compact-loading-skeleton branch April 15, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants