Skip to content

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented May 1, 2019

Fixes #9530

Note: This branch is based on #9765.
Merge instructions

  1. Review this PR
  2. Review and merge Add loading skeleton for compact items in posts list #9765
  3. Update the target branch to feature/post-filters-compat-view-toggle
  4. Review and merge this PR

Fixes design issues on the post list screen as requested in #9530 (comment) and fixes design issues for the post list items compact layout

Screenshots https://cloudup.com/isuSw0gKTf9

  • Replaced nested relativeLayouts with ContraintLayout and fixed several design issues in a6bc513, 3da04bc and 8eb8ff5

  • The divider for the compact view should be 1dp - Fixed in 76df211

  • use roboto/sans-serif for card labels. Card labels include: timestamps, post state labels (Local Changes, Private, Pending review etc.) - Fixed in c156edc

  • Increase padding on the right side of the author selection menu. The value used should be 24dp. - This is fixed in Issue/udpate author location #9697

  • Remove "W" list footers. We need to make sure we keep enough space on the base of the list to make sure the FAB is not covering any content as well. - Fixed in 79016b8, 5034654 and c6d1e9b

  • Adjust the body text line height/spacing to match the reader cards - c156edc

  • Copy: Change binned to trashed on "Trash" tab empty state - Fixed in 111e4d0

  • Remove bottom margin from progress bar, the progress bar should sit flush to the bottom of the card - The padding is added there by the system and I can't think of an easy not-hacky solution.

To test:

  1. My Site
  2. Post List
  3. Change view layout type by tapping on the action in the Toolbar
  4. Click on Drafts tab
  5. Click on Publish button on one of the items
  6. Verify the "uploading item" looks as in the screenshot
  7. Scroll to the bottom and make sure the FAB doesn't cover any content
  8. Click Trashed tab
  9. Either switch to a site with no drafts or delete all the drafts
  10. Make sure the empty view says "You don't have any trashed posts"

Update release notes:

  • The feature hasn't been released yet.

@malinajirka malinajirka added this to the 12.4 milestone May 1, 2019
@malinajirka malinajirka requested review from maxme, oguzkocer and shiki May 1, 2019 09:45
@malinajirka malinajirka added the Design Needed A design solution is needed. label May 1, 2019
@SylvesterWilmott
Copy link

All looks good! thanks @malinajirka

Copy link
Contributor

@shiki shiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I would like to clarify this with you, @SylvesterWilmott and @malinajirka

Adjust the body text line height/spacing to match the reader cards

I'm not quite sure what that entails but I noticed that the space between the feature image and the title are not the same for the Post List (left) and Reader (right):

2019-05-01 08 40 42 png 2019-05-01 08-43-16

Are they supposed to be?

@SylvesterWilmott
Copy link

I'm not quite sure what that entails but I noticed that the space between the feature image and the title are not the same for the Post List (left) and Reader (right):

@shiki good eye! Indeed, let's use the same spacing from the reader here @malinajirka

@malinajirka
Copy link
Contributor Author

Thanks @shiki - nice catch! ;)

I'm not quite sure what that entails but I noticed that the space between the feature image and the title are not the same for the Post List (left) and Reader (right):

let's use the same spacing from the reader here @malinajirka

Fixed in 3e706ce

@malinajirka malinajirka removed the Design Needed A design solution is needed. label May 2, 2019
Copy link
Contributor

@shiki shiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again. LGTM! 🎉

As you mentioned, I will not merge this until #9765 is merged.

@maxme maxme assigned maxme and shiki and unassigned maxme May 2, 2019
@maxme maxme changed the title Post list view toggle fix design issues feature/post-filters-compat-view-toggle May 2, 2019
@maxme maxme changed the base branch from issue/9763-compact-loading-skeleton to feature/post-filters-compat-view-toggle May 2, 2019 14:18
@maxme maxme changed the title feature/post-filters-compat-view-toggle Post list view toggle fix design issues May 2, 2019
@malinajirka
Copy link
Contributor Author

Thanks @shiki 🙇- #9765 has been merged.

@shiki
Copy link
Contributor

shiki commented May 2, 2019

Just did a quick merge and test with the target branch. Merging it in.

@shiki shiki merged commit b9e502f into feature/post-filters-compat-view-toggle May 2, 2019
@shiki shiki deleted the post-list-view-toggle-fix-design-issues branch May 8, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants