-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Post list view toggle fix design issues #9770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post list view toggle fix design issues #9770
Conversation
All looks good! thanks @malinajirka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would like to clarify this with you, @SylvesterWilmott and @malinajirka
Adjust the body text line height/spacing to match the reader cards
I'm not quite sure what that entails but I noticed that the space between the feature image and the title are not the same for the Post List (left) and Reader (right):
Are they supposed to be?
@shiki good eye! Indeed, let's use the same spacing from the reader here @malinajirka |
Thanks @shiki - nice catch! ;)
Fixed in 3e706ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again. LGTM! 🎉
As you mentioned, I will not merge this until #9765 is merged.
Just did a quick merge and test with the target branch. Merging it in. |
Fixes #9530
Note: This branch is based on #9765.
Merge instructions
feature/post-filters-compat-view-toggle
Fixes design issues on the post list screen as requested in #9530 (comment) and fixes design issues for the post list items compact layout
Screenshots https://cloudup.com/isuSw0gKTf9
Replaced nested relativeLayouts with ContraintLayout and fixed several design issues in a6bc513, 3da04bc and 8eb8ff5
The divider for the compact view should be 1dp
- Fixed in 76df211use roboto/sans-serif for card labels. Card labels include: timestamps, post state labels (Local Changes, Private, Pending review etc.)
- Fixed in c156edcIncrease padding on the right side of the author selection menu. The value used should be 24dp.
- This is fixed in Issue/udpate author location #9697Remove "W" list footers. We need to make sure we keep enough space on the base of the list to make sure the FAB is not covering any content as well.
- Fixed in 79016b8, 5034654 and c6d1e9bAdjust the body text line height/spacing to match the reader cards
- c156edcCopy: Change binned to trashed on "Trash" tab empty state
- Fixed in 111e4d0❓
Remove bottom margin from progress bar, the progress bar should sit flush to the bottom of the card
- The padding is added there by the system and I can't think of an easy not-hacky solution.To test:
Update release notes: