Inflate post list menu item from xml instead of adding it dynamically #9764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2019
maxme
approved these changes
May 2, 2019
| <string name="posts_draft_empty">You don\'t have any draft posts</string> | ||
| <string name="posts_trashed_empty">You don\'t have any binned posts</string> | ||
| <string name="multiple_status_label_delimiter" translatable="false">\u0020·\u0020</string> | ||
| <string name="post_list_toggle_item_view_layout">toggle rows view</string> |
There was a problem hiding this comment.
Might be nitpicking, but to improve accessibility, should we describe the change instead: "Switch to cards view" and "Switch to list view"?
There was a problem hiding this comment.
Good point! I'll create another PR for the fix so we don't block the PRs which are dependant on this one. Even though it's a really small change, I'll need to create an UiState for menu item to keep things consistent with other VMs. Does it sounds good?
There was a problem hiding this comment.
Yep sure, time to cascade merge everything :)
|
|
This was referenced May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9725
Inflate the "toggle posts list item view layout" button on the post list screen from the xml instead of adding the button dynamically using Kotlin.
To test:
Update release notes:
Note - This code was mostly developed by @onepointsixtwo in #9732, but the fork of the repo was deleted before we merged the PR.