Skip to content

Add '=' after '_h' for Horde_Url objects in signUrl()/signQueryString() #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TDannhauer merged 1 commit into from
Dec 19, 2025
Merged

Add '=' after '_h' for Horde_Url objects in signUrl()/signQueryString() #37

TDannhauer merged 1 commit into from
Dec 19, 2025

Conversation

@amulet1
Copy link
Contributor

@amulet1 amulet1 commented Dec 17, 2025

The horde/Url@bf2b51b restored the original behavior or Horde_Url ('=' is not added for parameters with empty values).

See #28 (comment).

@amulet1
fix: Add '=' after '_h' for Horde_Url objects in signUrl()/signQueryS…
27e694f 
…tring()

The most recent version of Horde_Url restored the original behavior ('=' is not added for parameters with empty values).
@amulet1
Copy link
Contributor Author

amulet1 commented Dec 17, 2025

@TDannhauer Please merge.

@TDannhauer
Copy link
Contributor

TDannhauer commented Dec 17, 2025

What symptoms fixes this change?

@amulet1
Copy link
Contributor Author

amulet1 commented Dec 17, 2025 •
edited
Loading

It fixes horde/base#12 (again).

Here is what happened:

  1. Commit horde/Url@523d5e5b introduced multiple issues (Horde_Url no longer passing tests, '=' added for empty parameter values, not converting Horde_Url objects to string, etc.).
  2. The Remove extraneous '=' in signUrl() and signQueryString() #28 fixed the '=' part of it in order to close Messed up URL when redirecting to auth during login or refresh base#12.
  3. Reimplement parameters encoding in Horde_Url's toString() method to restore the intended functionality Url#4 (just merged) fixed all other broken things, but it also restored the original handling of empty values (i.e. does not add '=').
  4. That is why we now need to add back '='.

@TDannhauer TDannhauer merged commit 3ff2626 into horde:FRAMEWORK_6_0 Dec 19, 2025
0 of 4 checks passed
@amulet1 amulet1 deleted the fix-signurl branch December 20, 2025 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TDannhauer TDannhauer TDannhauer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amulet1 @TDannhauer