Remove extraneous '=' in signUrl() and signQueryString() #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TDannhauer, please could you review/merge? |
This was referenced Aug 13, 2025
|
Once horde/Url#4 is approved, changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ralflang: This PR is opened instead of #27 (to utilize a different source branch).
The verification code in
verifySignedUrlandverifySignedQueryStringmethods expects the$datastring to be in the following format:{url_with_timestamp}&_h={hash}. The supplied hash is checked against the hash computed on{url_with_timestamp}&_h=part.However, both
signUrlandsignQueryStringadd an extra=(only in case if the supplied parameter is an instance ofHorde_Urlclass), i.e. a hash is computed on{url_with_timestamp}&_h==, and the subsequent verification fails.This is required (but not enough) in order to resolve horde/base#12.