Reimplement parameters encoding in Horde_Url's toString() method to restore the intended functionality #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
(string)(this takes care ofHorde_Url)[and]This also fixes the test failures mentioned in #2.
With this PR, instances of classes without
__toString()will not be encoded the wayhttp_build_querywould encode them, but this is how it was before 523d5e5, anyway.More tests should be added, specifically to test nested arrays (possible with
Horde_Url), e.g.