Skip to content

Conversation

alllex
Copy link
Member

@alllex alllex commented Jan 14, 2025

Annotate allProject-scoped services with the appropriate service scopes, and require any new services to be properly annotated.

Follow-up for #31990

The changes are across many files but they are mostly trivial and of two types:

  • Add a missing @ServiceScope annotation to the service interface/class
  • Update service registration by exposing only the service interface, instead of the service implementation

The latter is done either by updating the returned type from a factory method or by adding an explicit service type in the registration.add() call.

@alllex alllex force-pushed the alllex/gist/strict-project-scope branch from 52d23cb to 7e569a6 Compare January 14, 2025 16:44
@alllex alllex self-assigned this Jan 14, 2025
@alllex alllex added a:chore Minor issue without significant impact in:internal-services Internal services dependency injection labels Jan 14, 2025
@alllex alllex force-pushed the alllex/gist/strict-project-scope branch from 86bcecf to ce869ea Compare January 14, 2025 23:31
@alllex

This comment has been minimized.

@bot-gradle

This comment has been minimized.

@alllex alllex force-pushed the alllex/gist/strict-project-scope branch from ce869ea to ab80198 Compare January 15, 2025 00:05
@bot-gradle

This comment has been minimized.

@alllex

This comment has been minimized.

@bot-gradle

This comment has been minimized.

@bot-gradle

This comment has been minimized.

@alllex

This comment has been minimized.

@bot-gradle

This comment has been minimized.

@bot-gradle
Copy link
Collaborator

The following builds have failed:

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. If you don't want the stale bot to close it, then set a milestone for it.

@github-actions github-actions bot added the stale label Feb 14, 2025
@alllex alllex removed the stale label Feb 14, 2025
@alllex alllex force-pushed the alllex/gist/strict-project-scope branch from b2f1d76 to 33150b5 Compare March 4, 2025 10:29
@alllex
Copy link
Member Author

alllex commented Mar 4, 2025

@bot-gradle test on linux without pts

@bot-gradle

This comment has been minimized.

@bot-gradle
Copy link
Collaborator

The following builds have failed:

@alllex alllex force-pushed the alllex/gist/strict-project-scope branch from 68a3985 to 105b454 Compare March 7, 2025 22:24
@alllex
Copy link
Member Author

alllex commented Mar 11, 2025

Superseded by #32646

@alllex alllex closed this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:chore Minor issue without significant impact in:internal-services Internal services dependency injection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants