Annotate BuildTree-scope services #31990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with respect to service annotations
e5889f5 to
34bd938
Compare
|
@bot-gradle test without pts |
This comment has been minimized.
This comment has been minimized.
|
The following builds have passed: |
alllex
commented
Jan 13, 2025
| public BuildTreeState(BuildInvocationScopeId buildInvocationScopeId, ServiceRegistry parent, BuildTreeModelControllerServices.Supplier modelServices) { | ||
| services = ServiceRegistryBuilder.builder() | ||
| .scope(Scope.BuildTree.class) | ||
| .scopeStrictly(Scope.BuildTree.class) |
There was a problem hiding this comment.
ℹ️ Ensure services in the scope are strictly annotated
ov7a
reviewed
Jan 13, 2025
| "org.gradle.cache.internal.ProducerGuard", | ||
| "org.gradle.internal.typeconversion.NotationParser", | ||
|
|
||
| "org.gradle.caching.internal.origin.OriginMetadataFactory", |
There was a problem hiding this comment.
💅 would be nice to have a comment describing the reason for suppression
alllex
added a commit
that referenced
this pull request
Jan 22, 2025
reinsch82
pushed a commit
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotate all
BuildTree-scoped services with the appropriate service scopes, and require any new services to be properly annotated.Follow-up for #31965
The changes are across many files but they are mostly trivial and of two types:
@ServiceScopeannotation to the service interface/classThe latter is done either by updating the returned type from a factory method or by adding an explicit service type in the registration.add() call.