Annotate remaining Project-scoped services #32646
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The following builds have failed: |
|
@bot-gradle test without pts |
This comment has been minimized.
This comment has been minimized.
|
The following builds have passed: |
| import java.io.File; | ||
|
|
||
| @ServiceScope(Scope.Project.class) | ||
| public class DefaultProjectLayout implements ProjectLayout, TaskFileVarFactory { |
There was a problem hiding this comment.
Could this be dropped if we registered ProjectLayout as the service?
There was a problem hiding this comment.
We already register it as a service. The current reason is due to DefaultProject injecting the implementation, rather than the interfaces:
It seems, this is only due to the need to do DefaultProjectLayout#setBuildDirectory, which according to the comment should go away:
It's a nice catch, I'll fix it in a follow-up to avoid mixing non-trivial changes to this PR.
There was a problem hiding this comment.
Here is the follow-up. It resolved your question, but also uncovered more questions about the buildDirectory setter
Annotates remaining Project-scope services and makes the Project-scope service registry strictly requiring the annotations.
Follows up after #32636