Configure lifecycle tasks for all projects without filtering subprojects #14440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran the full "ready for release" pipeline for this change: https://builds.gradle.org/viewLog.html?buildId=37864357 |
rieske
commented
Sep 7, 2020
Comment on lines
+49
to
+51
| named("quickTest") { | ||
| dependsOn("embeddedIntegTest") | ||
| } |
There was a problem hiding this comment.
I am not confident with the change because now soak tests can be triggered using quickTest lifecycle task, which is probably not semantically correct.
rieske
commented
Sep 7, 2020
| id("gradlebuild.classycle") | ||
| id("gradlebuild.integration-tests") | ||
| id("gradlebuild.cross-version-tests") | ||
| id("gradlebuild.ci-lifecycle") |
There was a problem hiding this comment.
Not sure if it is a good idea to add a separate plugin here and not register the lifecycle tasks directly in java-library plugin.
soak,distributions-integ-testsandarchitecture-testsubprojects are executed on CI using different lifecycle tasks than the rest.They are currently filtered out and do not have the usual lifecycle tasks that all the other subprojects have registered.
They are also filtered in
GradleSubprojectProviderTeamCity configuration and executed using their own dedicated lifecycle tasks.This change registers the lifecycle tasks for all the subprojects without filtering them. TeamCity configuration still filters and picks which subprojects to execute when and using which lifecycle task.