Configure lifecycle tasks for all projects without filtering subprojects #14440
Conversation
|
I ran the full "ready for release" pipeline for this change: https://builds.gradle.org/viewLog.html?buildId=37864357 |
| named("quickTest") { | ||
| dependsOn("embeddedIntegTest") | ||
| } |
There was a problem hiding this comment.
I am not confident with the change because now soak tests can be triggered using quickTest lifecycle task, which is probably not semantically correct.
| id("gradlebuild.classycle") | ||
| id("gradlebuild.integration-tests") | ||
| id("gradlebuild.cross-version-tests") | ||
| id("gradlebuild.ci-lifecycle") |
There was a problem hiding this comment.
Not sure if it is a good idea to add a separate plugin here and not register the lifecycle tasks directly in java-library plugin.
There was a problem hiding this comment.
I think both solutions are fine.
| group = "verification" | ||
| dependsOn( | ||
| "compileAll", ":docs:checkstyleApi", "codeQuality", ":internal-build-reports:allIncubationReportsZip", | ||
| ":docs:checkstyleApi", ":internal-build-reports:allIncubationReportsZip", |
There was a problem hiding this comment.
We don't need to do it now, but eventually it would be better if we won't have to add a sanityCheck task to the root proejct at all. Instead the "sanityCheck" of the subprojects in question here should get extended in the places where the corresponding tasks --- like allIncubationReportsZip -- are created.
Same for compileAll/services:createBuildReceipt above.
| id("gradlebuild.classycle") | ||
| id("gradlebuild.integration-tests") | ||
| id("gradlebuild.cross-version-tests") | ||
| id("gradlebuild.ci-lifecycle") |
There was a problem hiding this comment.
I think both solutions are fine.
| named("quickTest") { | ||
| dependsOn("embeddedIntegTest") | ||
| } |
soak,distributions-integ-testsandarchitecture-testsubprojects are executed on CI using different lifecycle tasks than the rest.They are currently filtered out and do not have the usual lifecycle tasks that all the other subprojects have registered.
They are also filtered in
GradleSubprojectProviderTeamCity configuration and executed using their own dedicated lifecycle tasks.This change registers the lifecycle tasks for all the subprojects without filtering them. TeamCity configuration still filters and picks which subprojects to execute when and using which lifecycle task.