Configure lifecycle tasks for all projects without filtering subprojects #14440
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| /* | ||
| * Copyright 2020 the original author or authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package gradlebuild | ||
|
|
||
| tasks.registerEarlyFeedbackLifecycleTasks() | ||
| tasks.named("quickTest") { | ||
| dependsOn("test") | ||
| } | ||
| tasks.named("platformTest") { | ||
| dependsOn("test") | ||
| } | ||
| tasks.configureCIIntegrationTestDistributionLifecycleTasks() | ||
| tasks.configureCICrossVersionTestDistributionLifecycleTasks() | ||
|
|
||
| val ciGroup = "CI Lifecycle" | ||
|
|
||
| /** | ||
| * Basic compile and check lifecycle tasks. | ||
| */ | ||
| fun TaskContainer.registerEarlyFeedbackLifecycleTasks() { | ||
| register("compileAllBuild") { | ||
| description = "Initialize CI Pipeline by priming the cache before fanning out" | ||
| group = ciGroup | ||
| dependsOn("compileAll") | ||
| } | ||
|
|
||
| register("sanityCheck") { | ||
| description = "Run all basic checks (without tests) - to be run locally and on CI for early feedback" | ||
| group = "verification" | ||
| dependsOn("compileAll", "codeQuality") | ||
| } | ||
| } | ||
|
|
||
| fun TaskContainer.configureCIIntegrationTestDistributionLifecycleTasks() { | ||
| named("quickTest") { | ||
| dependsOn("embeddedIntegTest") | ||
| } | ||
|
Comment on lines
+49
to
+51
There was a problem hiding this comment. I am not confident with the change because now |
||
|
|
||
| named("platformTest") { | ||
| dependsOn("forkingIntegTest") | ||
| } | ||
|
|
||
| named("allVersionsIntegMultiVersionTest") { | ||
| dependsOn("integMultiVersionTest") | ||
| } | ||
|
|
||
| named("parallelTest") { | ||
| dependsOn("parallelIntegTest") | ||
| } | ||
|
|
||
| named("noDaemonTest") { | ||
| dependsOn("noDaemonIntegTest") | ||
| } | ||
|
|
||
| named("configCacheTest") { | ||
| dependsOn("configCacheIntegTest") | ||
| } | ||
|
|
||
| named("watchFsTest") { | ||
| dependsOn("watchFsIntegTest") | ||
| } | ||
|
|
||
| named("forceRealizeDependencyManagementTest") { | ||
| dependsOn("integForceRealizeTest") | ||
| } | ||
| } | ||
|
|
||
| fun TaskContainer.configureCICrossVersionTestDistributionLifecycleTasks() { | ||
| named("quickTest") { | ||
| dependsOn("embeddedCrossVersionTest") | ||
| } | ||
|
|
||
| named("platformTest") { | ||
| dependsOn("forkingCrossVersionTest") | ||
| } | ||
|
|
||
| named("quickFeedbackCrossVersionTest") { | ||
| dependsOn("quickFeedbackCrossVersionTests") | ||
| } | ||
|
|
||
| named("allVersionsCrossVersionTest") { | ||
| dependsOn("allVersionsCrossVersionTests") | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to do it now, but eventually it would be better if we won't have to add a sanityCheck task to the root proejct at all. Instead the "sanityCheck" of the subprojects in question here should get extended in the places where the corresponding tasks --- like
allIncubationReportsZip-- are created.Same for compileAll/services:createBuildReceipt above.