Skip to content

feat(fossology): Support for Bionic Beaver #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2018
Merged

feat(fossology): Support for Bionic Beaver #1116

merged 2 commits into from
Sep 14, 2018

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jun 7, 2018 •
edited
Loading

Fixes

  1. Change dependency from heirloom-mailx to heirloom-mailx | s-nail (alias).
  2. Nomos: change sprintf statements to handle longer strings without unexpected results.
  3. Added dependencies for bionic
  4. Change Object class to ObjectType
  5. Added PHP 7.2 tests in Travis as allow failure (can be made necessary)

Updates

  1. Updated composer dependencies.

Drop support

(Already dropped by #1153)
Dropped support for following distros as they are no longer supported by their producer/developer.

Code name Distro Version Link
Lenny Debian 5 https://wiki.debian.org/DebianLenny
Squeeze Debian 6 https://www.debian.org/releases/squeeze/
Hardy Ubuntu 8.04 https://wiki.ubuntu.com/Releases
Lucid Ubuntu 10.04
Natty Ubuntu 11.04
Oneiric Ubuntu 11.10
Precise Ubuntu 12.04
Quantal Ubuntu 12.10
Raring Ubuntu 13.04
Saucy Ubuntu 13.10
Yakkety Ubuntu 16.10
Isadora Linux Mint 9 https://blog.linuxmint.com/?p=1403

Closes #1007

@ghost ghost assigned GMishx Jun 7, 2018
@GMishx GMishx removed their assignment Jun 7, 2018
@GMishx GMishx force-pushed the feat/bionicsupport branch from 8d9f4c4 to 1e5d561 Compare June 7, 2018 12:48
@ghost ghost assigned GMishx Jun 7, 2018
@GMishx GMishx removed their assignment Jun 7, 2018
@GMishx
Copy link
Member Author

GMishx commented Jun 11, 2018

There is a problem with PHP 7.2 which is the default version of PHP in Ubuntu Bionic.
The Object is a hard reserved keyword and thus getting the following error:
PHP Fatal error: Cannot use 'Object' as class name as it is reserved in /usr/local/share/fossology/lib/php/Util/Object.php on line 5
Any thoughts on the same?

@GMishx GMishx added the WIP label Jun 14, 2018
@GMishx GMishx changed the title feat(fossology): Support for Bionic Beaver WIP: feat(fossology): Support for Bionic Beaver Jul 10, 2018
@GMishx GMishx force-pushed the feat/bionicsupport branch from 1e5d561 to 217d01a Compare July 10, 2018 15:01
@ghost ghost assigned GMishx Jul 10, 2018
@ghost ghost removed the WIP label Jul 10, 2018
@GMishx GMishx changed the title WIP: feat(fossology): Support for Bionic Beaver feat(fossology): Support for Bionic Beaver Jul 10, 2018
@GMishx GMishx requested review from ag4ums and shaheemazmalmmd July 10, 2018 15:03
@GMishx
Copy link
Member Author

GMishx commented Jul 10, 2018

Changed the class name from Object to ObjectType to fix the issue. Also need to be updated in the wiki.
https://github.com/fossology/fossology/wiki/PHP-Object-Baseclass (link for the same in Home)

@GMishx GMishx force-pushed the feat/bionicsupport branch from 217d01a to f4955d4 Compare July 10, 2018 15:17
@GMishx GMishx added the WIP label Jul 10, 2018
@ghost ghost removed the WIP label Jul 11, 2018
@GMishx GMishx force-pushed the feat/bionicsupport branch 2 times, most recently from b97afc2 to 400c0cc Compare July 11, 2018 06:48
@GMishx GMishx force-pushed the feat/bionicsupport branch 7 times, most recently from 40d1974 to dac5ea8 Compare July 11, 2018 11:35
@GMishx GMishx force-pushed the feat/bionicsupport branch from b393709 to d996571 Compare August 23, 2018 08:42
@ghost ghost assigned GMishx Aug 23, 2018
@GMishx GMishx removed their assignment Aug 23, 2018
@GMishx GMishx force-pushed the feat/bionicsupport branch from d996571 to 7464199 Compare August 24, 2018 08:27
@ghost ghost assigned GMishx Aug 24, 2018
@GMishx GMishx force-pushed the feat/bionicsupport branch from 7464199 to db2ed3c Compare August 24, 2018 08:30
@GMishx GMishx removed their assignment Aug 24, 2018
@ghost ghost assigned GMishx Aug 24, 2018
@robertvolkmann
Copy link
Contributor

@GMishx Do we really need the class Object/ObjectType?

Since PHP 5.5, the class keyword is also used for class name resolution. You can get a string containing the fully qualified name of the ClassName class by using ClassName::class.

See: https://secure.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class

This was referenced Aug 27, 2018
Merged
Merged
robertvolkmann
robertvolkmann previously requested changes Aug 27, 2018
View reviewed changes
src/copyright/agent_tests/Functional/schedulerTest.php Outdated
}

// PHP unit 7 compatibility
if (class_exists('\PHPUnit\Framework\TestCase') && !class_exists('\PHPUnit_Framework_TestCase')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this change already for PHPUnit 6. See #1179.

src/lib/php/Util/ObjectType.php Outdated
namespace Fossology\Lib\Util;

class Object
class ObjectType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this class anymore. See #1180.

@robertvolkmann
Copy link
Contributor

robertvolkmann commented Aug 27, 2018 •
edited
Loading

The development dependency Mockery does not support PHPUnit 7.

See: mockery/mockery#850

@maxhbr maxhbr added the has merge conflicts PR to be rebased label Aug 28, 2018
@GMishx GMishx force-pushed the feat/bionicsupport branch from cf6149c to 5a41155 Compare August 29, 2018 05:43
@GMishx GMishx removed the has merge conflicts PR to be rebased label Aug 29, 2018
@GMishx GMishx force-pushed the feat/bionicsupport branch from 5a41155 to 52373a4 Compare August 29, 2018 05:55
@robertvolkmann
Copy link
Contributor

@GMishx Can you move your PHP formatting changes in a separate PR?

@GMishx GMishx force-pushed the feat/bionicsupport branch from 52373a4 to 1b18bec Compare August 30, 2018 06:31
@GMishx
feat(fossology): Support for Bionic Beaver
e9345a2 
fix(debian/control): Change dependency from heirloom-mailx
heirloom-mailx | s-nail
fix(DMalloc.c): Initialize i
fix(license.c): Change sprintf to handle longer strings
without unexpected results.
fix(nomos_utils.c): Change NULL_CHAR to NULL to compare
fix(util.c): Change sprintf to handle longer strings
withour unexpected results.
fix(database.c): Initialize variables

feat(Makefile): Add flag for RPM 4.14
feat(pkgagent.c): Changes according to RPM 4.14
feat(fo-installdeps): Added support for Ubuntu Bionic
Beaver

feat(fo-installdeps): Drop support for
Lenny, Hardy, Squeeze, Lucid, Natty, Isadora,
Precise, Oneiric, Quantal, Raring, Saucy,
Yakkety
As they are no longer supported by their producer/developer.

Signed-off-by: Gaurav Mishra <[email protected]>
@GMishx
fix(deps): Add Boost runtime dependencies
d277eb7 
fix(php-conf-fix): Use regex/awk to find php.ini path.
feat(.travis.yml): Added tests for PHP 7.2 as allow failure.

See fossology#1175 for more.

Signed-off-by: Gaurav Mishra <[email protected]>
@GMishx GMishx force-pushed the feat/bionicsupport branch from 1b18bec to d277eb7 Compare September 4, 2018 11:32
ag4ums
ag4ums approved these changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes loos good, code is working fine

@mcjaeger mcjaeger assigned mcjaeger and unassigned ag4ums and GMishx Sep 12, 2018
@robertvolkmann robertvolkmann dismissed their stale review September 13, 2018 15:52

All comments was satisfied.

@ag4ums ag4ums merged commit 08d4452 into fossology:master Sep 14, 2018
@ghost ghost removed the in review label Sep 14, 2018
@GMishx GMishx deleted the feat/bionicsupport branch November 12, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ag4ums ag4ums ag4ums approved these changes

@shaheemazmalmmd shaheemazmalmmd Awaiting requested review from shaheemazmalmmd

+1 more reviewer

@robertvolkmann robertvolkmann robertvolkmann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mcjaeger mcjaeger

Labels

needs test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GMishx @robertvolkmann @ag4ums @maxhbr @mcjaeger