Skip to content

Conversation

robertvolkmann
Copy link
Contributor

@robertvolkmann robertvolkmann commented Aug 27, 2018

Description

Add forward compatibility for the following change in PHPUnit 6

PHPUnit's units of code are now namespaced. For instance, PHPUnit_Framework_TestCase is now `PHPUnit\Framework\TestCase

by implementing

Added phpunit\framework\TestCase as an alias for PHPUnit_Framework_TestCase for forward compatibility

See: https://github.com/sebastianbergmann/phpunit/wiki/Release-Announcement-for-PHPUnit-6.0.0
See: https://github.com/sebastianbergmann/phpunit/blob/5.4/ChangeLog-5.4.md

How to test

Run all tests or check the logs on travis-ci.

Thanks to @GMishx for pointing out this backwards compatibility issue in #1116

Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tests are working fine.

@GMishx GMishx merged commit 3ceca0c into fossology:master Aug 28, 2018
@robertvolkmann robertvolkmann deleted the feat/phpunit-namespaced branch August 28, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants