Skip to content

feat(fossology): Support for Bionic Beaver #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2018
Merged

feat(fossology): Support for Bionic Beaver #1116

merged 2 commits into from
Sep 14, 2018

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Jun 7, 2018 •
edited
Loading

Fixes

  1. Change dependency from heirloom-mailx to heirloom-mailx | s-nail (alias).
  2. Nomos: change sprintf statements to handle longer strings without unexpected results.
  3. Added dependencies for bionic
  4. Change Object class to ObjectType
  5. Added PHP 7.2 tests in Travis as allow failure (can be made necessary)

Updates

  1. Updated composer dependencies.

Drop support

(Already dropped by #1153)
Dropped support for following distros as they are no longer supported by their producer/developer.

Code name Distro Version Link
Lenny Debian 5 https://wiki.debian.org/DebianLenny
Squeeze Debian 6 https://www.debian.org/releases/squeeze/
Hardy Ubuntu 8.04 https://wiki.ubuntu.com/Releases
Lucid Ubuntu 10.04
Natty Ubuntu 11.04
Oneiric Ubuntu 11.10
Precise Ubuntu 12.04
Quantal Ubuntu 12.10
Raring Ubuntu 13.04
Saucy Ubuntu 13.10
Yakkety Ubuntu 16.10
Isadora Linux Mint 9 https://blog.linuxmint.com/?p=1403

Closes #1007

@ghost ghost assigned GMishx Jun 7, 2018
@GMishx GMishx removed their assignment Jun 7, 2018
@GMishx GMishx force-pushed the feat/bionicsupport branch from 8d9f4c4 to 1e5d561 Compare June 7, 2018 12:48
@ghost ghost assigned GMishx Jun 7, 2018
@GMishx GMishx removed their assignment Jun 7, 2018
@GMishx
Copy link
Member Author

GMishx commented Jun 11, 2018

There is a problem with PHP 7.2 which is the default version of PHP in Ubuntu Bionic.
The Object is a hard reserved keyword and thus getting the following error:
PHP Fatal error: Cannot use 'Object' as class name as it is reserved in /usr/local/share/fossology/lib/php/Util/Object.php on line 5
Any thoughts on the same?

@GMishx GMishx added the WIP label Jun 14, 2018
@GMishx GMishx changed the title feat(fossology): Support for Bionic Beaver WIP: feat(fossology): Support for Bionic Beaver Jul 10, 2018
@GMishx GMishx force-pushed the feat/bionicsupport branch from 1e5d561 to 217d01a Compare July 10, 2018 15:01
@ghost ghost assigned GMishx Jul 10, 2018
@ghost ghost removed the WIP label Jul 10, 2018
@GMishx GMishx changed the title WIP: feat(fossology): Support for Bionic Beaver feat(fossology): Support for Bionic Beaver Jul 10, 2018
@GMishx GMishx requested review from ag4ums and shaheemazmalmmd July 10, 2018 15:03
@GMishx
Copy link
Member Author

GMishx commented Jul 10, 2018

Changed the class name from Object to ObjectType to fix the issue. Also need to be updated in the wiki.
https://github.com/fossology/fossology/wiki/PHP-Object-Baseclass (link for the same in Home)