Bump up to beta1 #861
Bump up to beta1 #861
Conversation
|
[retest] |
TomSweeneyRedHat
left a comment
There was a problem hiding this comment.
LGTM. Very nifty piece of coding @mrunalp
|
@umohnani8 We need this to be added to kpod version and kpod info. |
|
LGTM, Don't stop update Beta waiting for kpod to include it. |
|
Working on it! |
|
@umohnani8 I think kpod versions shouldn't have to match cri-o. We could add a separate version file for kpod as it can't be 1.0 same time as cri-o while we are still working on adding features. |
|
Agree with not tying kpod to cri-o for versioning - they're two very different tools that are maturing at different speeds. |
|
Yeah no kpod version == cri-o version. LGTM |
|
30/31 passed on RHEL - Failed. 138/138 passed on Fedora - Passed. |
|
[retest] |
|
30/31 passed on RHEL - Failed. 138/138 passed on Fedora - Passed. |
Signed-off-by: Mrunal Patel <[email protected]>
We add a VERSION file and pass the gitCommit and version to the binary builds in the Makefile. Signed-off-by: Mrunal Patel <[email protected]>
|
Rebased. |
|
[retest] |
|
Sure I have no problem with the versions mismatch, but the github reference stuff should be the same. |
|
@mrunalp BTW I think we should refer to this as RC1, rather then Beta1. |
|
sure, I'll change it. |
|
[retest] |
there wasn't any job triggered actually |
|
@mrunalp Should we close this? |
Fixes #825
We also add support for displaying commit in --version.
Wait for #860 to be merged before merging this.
@runcom @rhatdan