Skip to content

Conversation

@mrunalp
Copy link
Member

@mrunalp mrunalp commented Sep 8, 2017

Closes #861

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 8, 2017
@mrunalp
Copy link
Member Author

mrunalp commented Sep 8, 2017

[retest]

@runcom
Copy link
Member

runcom commented Sep 8, 2017

LGTM

1 similar comment
@rhatdan
Copy link
Contributor

rhatdan commented Sep 8, 2017

LGTM

@rh-atomic-bot
Copy link

138/138 passed on RHEL - Passed.
121/121 k8s node-e2e passed on RHEL - Passed.

138/138 passed on Fedora - Passed.
121/121 k8s node-e2e passed on Fedora - Passed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/1514/fullresults.txt

@runcom
Copy link
Member

runcom commented Sep 8, 2017

🎉

@mrunalp
Copy link
Member Author

mrunalp commented Sep 8, 2017

@runcom @rhatdan Can one of you please merge? :)

We add a VERSION file and pass the gitCommit and version
to the binary builds in the Makefile.

Signed-off-by: Mrunal Patel <[email protected]>
@runcom
Copy link
Member

runcom commented Sep 8, 2017

I'll merge after Travis :)

@runcom runcom merged commit bb1da97 into cri-o:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants