Skip to content

Conversation

@umohnani8
Copy link
Member

Pulled in the changes from #861 and updated the version for kpod.

@umohnani8 umohnani8 mentioned this pull request Sep 7, 2017
@mrunalp
Copy link
Member

mrunalp commented Sep 7, 2017

Let us use a different KPOD_VERSION file here.

@umohnani8
Copy link
Member Author

okay, what should the version be in the KPOD_VERSION file?

@mheon
Copy link
Collaborator

mheon commented Sep 7, 2017

I think kpod is still alpha quality. @mrunalp @rhatdan Thoughts?

@mrunalp
Copy link
Member

mrunalp commented Sep 7, 2017

We could start at 0.1

@mrunalp mrunalp changed the title Version kpod version Sep 7, 2017
@umohnani8
Copy link
Member Author

umohnani8 commented Sep 7, 2017

@mrunalp @mheon PTAL.

@mheon
Copy link
Collaborator

mheon commented Sep 7, 2017

LGTM pending tests

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes labels Sep 7, 2017
@TomSweeneyRedHat
Copy link
Contributor

Code LGTM, but Travis isn't happy.

@umohnani8 umohnani8 force-pushed the version branch 2 times, most recently from 9e6e16d to 32a4471 Compare September 8, 2017 14:31
@umohnani8
Copy link
Member Author

Rebased

@umohnani8
Copy link
Member Author

[retest]

@rhatdan
Copy link
Contributor

rhatdan commented Sep 8, 2017

Definitely alpha, we need RUN/EXEC/CREATE before we can consider this beta.

@rhatdan
Copy link
Contributor

rhatdan commented Sep 8, 2017

LGTM

@umohnani8
Copy link
Member Author

Travis is failing on not ok 26 run ctr with image with Config.Volumes. Any reason why?

@rhatdan
Copy link
Contributor

rhatdan commented Sep 8, 2017

Could be a flake? Retrying.

@rhatdan
Copy link
Contributor

rhatdan commented Sep 8, 2017

Passes now.

@rhatdan
Copy link
Contributor

rhatdan commented Sep 9, 2017

@umohnani8 Needs rebase.

@umohnani8
Copy link
Member Author

Rebased

@rhatdan
Copy link
Contributor

rhatdan commented Sep 11, 2017

[retest]

@rh-atomic-bot
Copy link

143/143 passed on RHEL - Passed.
149/149 k8s e2e passed on RHEL - Passed.

143/143 passed on Fedora - Passed.
149/149 k8s e2e passed on Fedora - Passed.

Log - https://aos-ci.s3.amazonaws.com/kubernetes-incubator/cri-o/crio-integration-tests-prs/1535/fullresults.txt

@rhatdan
Copy link
Contributor

rhatdan commented Sep 11, 2017

Merging.

@rhatdan rhatdan merged commit c56dcf2 into cri-o:master Sep 11, 2017
@umohnani8 umohnani8 deleted the version branch January 31, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants