This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Double Timeout Variables for HTTP Requests and Triple the Timeout for the Transaction to ensure less timeouts are received with bad networking (EXPOSUREAPP-2190) #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corona-Warn-App/src/main/java/de/rki/coronawarnapp/http/config/HTTPVariables.kt
Show resolved
Hide resolved
… to ensure less timeouts are received with bad networking. (EXPOSUREAPP-2190) Adjusted to 3 Minutes. Signed-off-by: d067928 <[email protected]>
64308e4 to
206b181
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
chris-cwa
approved these changes
Sep 10, 2020
This was referenced Sep 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is done to ensure that we receive less Timeouts during bad networking or situations where the key retrieval takes longer. The PR can be tested by manually throttling the device network throughput and experiencing no timeout with HTTP Requests above 10 seconds and Transactions above 60s