Skip to content
This repository was archived by the owner on Jun 20, 2023. It is now read-only.

Double Timeout Variables for HTTP Requests and Triple the Timeout for the Transaction to ensure less timeouts are received with bad networking (EXPOSUREAPP-2190) #1138

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Double Timeout Variables for HTTP Requests and Triple the Timeout for the Transaction to ensure less timeouts are received with bad networking (EXPOSUREAPP-2190) #1138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
206b181
fixup! Double Timeout Variables for HTTP Requests and the Transaction…
jakobmoellerdev Sep 10, 2020
4e7800c
Merge branch 'dev' into fix/timeout-value-increase
jakobmoellerdev Sep 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Corona-Warn-App/src/main/java/de/rki/coronawarnapp/http/config/HTTPVariables.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ object HTTPVariables {
* The maximal runtime of a transaction
* In milliseconds
*/
private const val HTTP_CONNECTION_TIMEOUT = 10000L
private const val HTTP_CONNECTION_TIMEOUT = 20000L

/**
* Getter function for [HTTP_CONNECTION_TIMEOUT]
Expand All @@ -19,7 +19,7 @@ object HTTPVariables {
* The maximal runtime of a transaction
* In milliseconds
*/
private const val HTTP_READ_TIMEOUT = 10000L
private const val HTTP_READ_TIMEOUT = 20000L

/**
* Getter function for [HTTP_READ_TIMEOUT]
Expand All @@ -33,7 +33,7 @@ object HTTPVariables {
* The maximal runtime of a transaction
* In milliseconds
*/
private const val HTTP_WRITE_TIMEOUT = 10000L
private const val HTTP_WRITE_TIMEOUT = 20000L

/**
* Getter function for [HTTP_WRITE_TIMEOUT]
Expand Down
2 changes: 1 addition & 1 deletion Corona-Warn-App/src/main/java/de/rki/coronawarnapp/risk/TimeVariables.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ object TimeVariables {
* The maximal runtime of a transaction
* In milliseconds
*/
private const val TRANSACTION_TIMEOUT = 60000L
private const val TRANSACTION_TIMEOUT = 180000L

/**
* Getter function for [TRANSACTION_TIMEOUT]
Expand Down
6 changes: 3 additions & 3 deletions Corona-Warn-App/src/test/java/de/rki/coronawarnapp/http/config/HTTPVariablesTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ class HTTPVariablesTest {

@Test
fun getHTTPConnectionTimeout() {
Assert.assertEquals(HTTPVariables.getHTTPConnectionTimeout(), 10000L)
Assert.assertEquals(HTTPVariables.getHTTPConnectionTimeout(), 20000L)
}

@Test
fun getHTTPReadTimeout() {
Assert.assertEquals(HTTPVariables.getHTTPReadTimeout(), 10000L)
Assert.assertEquals(HTTPVariables.getHTTPReadTimeout(), 20000L)
}

@Test
fun getHTTPWriteTimeout() {
Assert.assertEquals(HTTPVariables.getHTTPWriteTimeout(), 10000L)
Assert.assertEquals(HTTPVariables.getHTTPWriteTimeout(), 20000L)
}
}
2 changes: 1 addition & 1 deletion Corona-Warn-App/src/test/java/de/rki/coronawarnapp/risk/TimeVariablesTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class TimeVariablesTest {

@Test
fun getTransactionTimeout() {
Assert.assertEquals(TimeVariables.getTransactionTimeout(), 60000L)
Assert.assertEquals(TimeVariables.getTransactionTimeout(), 180000L)
}

@Test
Expand Down