[pkg/stanza][fileconsumer] - finalize archive's implementation #39901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91f3ea8 to
496796f
Compare
496796f to
ecce69e
Compare
|
@djaglowski @andrzej-stencel Looking forward to hear your thoughts on this approach 😄 |
This was referenced May 20, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
cc: @andrzej-stencel |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@andrzej-stencel Can you take a look when you're around? |
andrzej-stencel
approved these changes
Jul 24, 2025
|
Please address feedback and resolve conflict and mark ready to review again. |
|
Please look at the conflict. |
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…telemetry#39901) This PR finalizes the archive implementation and adds test case. It updates following things: 1. Updates tracker to track unmatched files as well. - Theoretically, we can perform a match against archive with a single fingerprint but it is not effecient as we'll need to access disk frequently. Refer open-telemetry#32727 (comment) for detailed discussion on this topic. - Thus, we first track all unmatched files and then perform match against archive to minimise disk access. 3. Introduces a `handleUnmatchedFiles` helper to create readers once archive matching is done. Relates: open-telemetry#38056 --------- Co-authored-by: Andrzej Stencel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finalizes the archive implementation and adds test case.
It updates following things:
exclude_older_thanis enabled #32727 (comment) for detailed discussion on this topic.handleUnmatchedFileshelper to create readers once archive matching is done.Relates: #38056