One thing remains i.e. to update Config struct to allow polls_to_archive to be unmarshalled. I think we can do that in documentation PR afterwards.

EDIT: as of now, this PR includes documentation and enabled the config. If needed, we can separate it out.

I'll add changelog in documentation PR, as that will enable the actual config.

Reviewing this PR was hard for me due to the complexity of the code. I'm worried that the code is getting even more complex with these changes. We should work on decreasing its complexity in future contributions.

I agree. I'll work on this part to reduce complexity of this specific piece of code.

@andrzej-stencel @djaglowski we can break this PR into multiple ones, in following way:

1. Separate out processUnmatchedFiles function in a smaller PR.
2. Integrate it with makeReaders function and add documentation and enable config.
3. Then, refactor as needed.

let me know what do you think.

I too am struggling to make sense of this level of complexity. Usually my response to this is to make smaller, more testable, packages which try to do less. Would it make sense to implement the archive as a small separate package?

Thanks for you comment!
It should be possible to move it to a small package. I'll keep you posted.

The handling of edge cases is elaborate. Can we start without them? (i.e. just reboot the archive under these rare circumstances)

@djaglowski
QQ: when you say this, you mean to reboot the archive if the pollsToArchive has changed, right? i.e. effectively removing the archive restoration for now and focus on integrating it to a new package first.

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Closed as inactive. Feel free to reopen if this PR is still being worked on.

Superseded by #39901