Proposed 0.33.0-b7 #1827
Merged
Proposed 0.33.0-b7 #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate ledger-data-test.js to cpp tests. Provide coverage for paging limits and input error cases.
Add basic ledger_request validation tests to replace the existing ledger.js tests. Provide tests that trigger some error conditions in RPC handling code.
varint is no longer used by NuDB. It is now only used by codec.h in nodestore and so has been moved there.
- Use std instead of custom Beast classes - Remove Beast heap block allocator - Remove function call timer
Current coverage is 71.80% (diff: 98.84%)@@ develop #1827 diff @@
==========================================
Files 871 872 +1
Lines 69787 70038 +251
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 49973 50292 +319
+ Misses 19814 19746 -68
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes PRs: #1813, #1816, #1818, #1822 and #1824