Move varint out of NuDB #1822
Move varint out of NuDB #1822
Conversation
varint is no longer used by NuDB. It is now only used by codec.h in nodestore and so has been moved there.
|
Can we edit I assume we can't easily fix this. If we can, we should. In that case, in addition to the above lines, the function |
|
I've updated the comment at the top. I found a place where we write multi-byte values, and so the difference in base shows up. My understanding is that this encoding is part of our database now, and so would be inconvenient to change. |
src/ripple/nodestore/impl/varint.h
Outdated
| #include <type_traits> | ||
|
|
||
| namespace beast { | ||
| namespace nudb { |
There was a problem hiding this comment.
This should ripple::NodeStore::detail instead of beast::nudb::detail.
There was a problem hiding this comment.
<slaps forehead> Fix pushed.
There was a problem hiding this comment.
Nik beat me to it...
The dependency on nudb/detail/stream.h (and field.h) looks a bit questionable now.
Should they be levelised out of nudb (they only appear to be used there and nodestore)?
There was a problem hiding this comment.
At the moment I don't see a better place for istream and ostream. I'm certainly open to suggestions though.
There was a problem hiding this comment.
nudb can't include any files outside of its own directory, so no.
Current coverage is 71.58% (diff: 75.00%)@@ develop #1822 diff @@
==========================================
Files 871 871
Lines 69787 69787
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 49973 49958 -15
- Misses 19814 19829 +15
Partials 0 0
|
|
👍 |
1 similar comment
|
👍 |
|
Merged as 8a6c7f9 |
varint is no longer used by NuDB. It is now only used by codec.h in
nodestore and so has been moved there.