Augment LedgerRequestRPC tests (RIPD-1270) #1818
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic ledger_request validation tests to replace the existing ledger.js tests. Provide tests that trigger some error conditions in RPC handling code.
Explicitly set target age in the ledger master so that ledger sweeping will not remove entries before they are requested by the unit test.
Current coverage is 71.65% (diff: 100%)@@ develop #1818 diff @@
==========================================
Files 871 871
Lines 69787 69909 +122
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 49973 50093 +120
- Misses 19814 19816 +2
Partials 0 0
|
|
I'm not sold on exposing |
Merged
|
Merged as fd061bb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic ledger_request validation tests to replace the existing
ledger.js tests. Provide tests that trigger some error conditions
in RPC handling code.