-
Notifications
You must be signed in to change notification settings - Fork 2.3k
README: Suggest user.email to be 41898282+github-actions[bot]@users.noreply.github.com
#1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To match squash merge user, else showing as two different users, see: SocketDev/socket-sdk-js@b0948d0
user.email to be 41898282+github-actions[bot]@users.noreply.github.com
jeffwidman
approved these changes
Apr 25, 2024
joshmgross
reviewed
Apr 25, 2024
cory-miller
commented
Apr 29, 2024
joshmgross
approved these changes
Apr 29, 2024
|
This user ID can be obtained from GitHub's API. |
This is carried over from #1184. Below is the original PR body. This PR updates the base for actions/checkout@v4
To get a proper GitHub Actions Bot annotation to a commit one should set the
user.nameanduser.emailto:There are some confusion around this in the
actions/org itself:github-actions[bot]+[email protected]which does not give a proper avatar on the commitgithub-actions[bot]+github-actions[bot]@users.noreply.github.com) apart from lacking the41898282+prefix to the emailActions service account+[email protected](Another interesting aspect of the linked to workflows is that some use
--localwhen setting the name and email, some use--globaland some does what is suggested here and use neither of--localand--global)Of note is also a third approach from the community, where it strives to achieve custom bot users (+ to get around the limitation of workflow created PR:s not running workflows): https://github.com/wow-actions/use-app-token Such a
env.BOT_NAMEwould be quite nice to have built in to use.An example generated with this setup can be found here: SocketDev/socket-sdk-js@24f0574
Generated with: https://github.com/SocketDev/workflows/blob/24190c5ca3aa54b086ff1666ed4486f6bc1e9ec9/.github/workflows/reusable-sync.yml#L118-L119
EDIT: Swapped the recommendation to include the prefix
41898282+as I found out that that's the email used when the bot does eg. squash commits and thus its otherwise showing up as being two different users, which looks a bit confusing. See eg: SocketDev/socket-sdk-js@b0948d0