Skip to content

feat: support AccessorProperty #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
9romise merged 16 commits into from
Jul 16, 2025
Merged

feat: support AccessorProperty #829

9romise merged 16 commits into from
Jul 16, 2025

Conversation

@9romise
Copy link
Member

@9romise 9romise commented Jun 10, 2025 •
edited
Loading

Description

Support AccessorProperty in:

  • indent
  • quotes
  • operator-linebreak
  • semi
  • semi-style
  • no-extra-semi
  • no-extra-parens
  • semi-spacing
  • computed-property-spacing
  • space-infix-ops
  • keyword-spacing

Linked Issues

resolve #777

Additional context

@codecov
Copy link

codecov bot commented Jun 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (ddd14c8) to head (e79abb4).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          95       95           
  Lines       18090    18109   +19     
  Branches     4675     4678    +3     
=======================================
+ Hits        18033    18052   +19     
  Misses         57       57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 25, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@stylistic/eslint-plugin@829

npm i https://pkg.pr.new/@eslint-stylistic/metadata@829

commit: e79abb4

@codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 725 bytes (0.09%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@stylistic/eslint-plugin-esm 771.88kB 725 bytes (0.09%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: @stylistic/eslint-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
rules/indent.js 35 bytes 69.43kB 0.05%
rules/no-extra-parens.js 94 bytes 42.69kB 0.22%
rules/keyword-spacing.js 146 bytes 17.68kB 0.83%
rules/semi.js 41 bytes 11.72kB 0.35%
rules/quotes.js 43 bytes 10.56kB 0.41%
rules/operator-linebreak.js 94 bytes 7.65kB 1.24%
rules/space-infix-ops.js 65 bytes 6.97kB 0.94%
rules/semi-spacing.js 33 bytes 6.78kB 0.49%
rules/computed-property-spacing.js 54 bytes 5.28kB 1.03%
rules/semi-style.js 22 bytes 3.93kB 0.56%
rules/no-extra-semi.js 98 bytes 3.25kB 3.11%

Files in rules/indent.js:

  • ./rules/indent/indent.ts → Total Size: 69.14kB

Files in rules/no-extra-parens.js:

  • ./rules/no-extra-parens/no-extra-parens.ts → Total Size: 42.34kB

Files in rules/keyword-spacing.js:

  • ./rules/keyword-spacing/keyword-spacing.ts → Total Size: 17.47kB

Files in rules/semi.js:

  • ./rules/semi/semi.ts → Total Size: 11.52kB

Files in rules/quotes.js:

  • ./rules/quotes/quotes.ts → Total Size: 10.31kB

Files in rules/operator-linebreak.js:

  • ./rules/operator-linebreak/operator-linebreak.ts → Total Size: 7.49kB

Files in rules/space-infix-ops.js:

  • ./rules/space-infix-ops/space-infix-ops.ts → Total Size: 6.81kB

Files in rules/semi-spacing.js:

  • ./rules/semi-spacing/semi-spacing.ts → Total Size: 6.64kB

Files in rules/computed-property-spacing.js:

  • ./rules/computed-property-spacing/computed-property-spacing.ts → Total Size: 5.16kB

Files in rules/semi-style.js:

  • ./rules/semi-style/semi-style.ts → Total Size: 3.8kB

Files in rules/no-extra-semi.js:

  • ./rules/no-extra-semi/no-extra-semi.ts → Total Size: 3.06kB

9romise added 4 commits July 3, 2025 13:52
@9romise
Merge branch 'main' into feat/accessor
a43cae7 
# Conflicts:
#	packages/eslint-plugin/rules/indent/indent._ts_.test.ts
#	packages/eslint-plugin/rules/indent/indent.ts
@9romise
test(semi): move to ts
88d0e71
@9romise
feat(semi-style): support AccessorProperty
5f97fb8
@9romise
feat(space-infix-ops): support AccessorProperty
7d6eb4d
@9romise 9romise marked this pull request as ready for review July 3, 2025 09:33
@9romise 9romise marked this pull request as draft July 3, 2025 09:56
@9romise 9romise marked this pull request as ready for review July 4, 2025 08:27
@9romise 9romise added this pull request to the merge queue Jul 16, 2025
Merged via the queue into eslint-stylistic:main with commit 2143f34 Jul 16, 2025
14 checks passed
@9romise 9romise deleted the feat/accessor branch July 16, 2025 06:12
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Merged
argocd-diff-action-bot bot pushed a commit to argocd-diff-action/argocd-diff-action that referenced this pull request Aug 19, 2025
@semantic-release-bot
chore(release): 0.5.4
b34d257 
## [0.5.4](0.5.3...0.5.4) (2025-08-19)

### Build & Dependencies

* **deps-dev:** bump @stylistic/eslint-plugin from 4.2.0 to 5.2.2 ([#163](#163)) ([3ae28b0](3ae28b0)), closes [eslint-stylistic/eslint-stylistic#905](eslint-stylistic/eslint-stylistic#905) [eslint-stylistic/eslint-stylistic#907](eslint-stylistic/eslint-stylistic#907) [eslint-stylistic/eslint-stylistic#887](eslint-stylistic/eslint-stylistic#887) [eslint-stylistic/eslint-stylistic#903](eslint-stylistic/eslint-stylistic#903) [eslint-stylistic/eslint-stylistic#886](eslint-stylistic/eslint-stylistic#886) [eslint-stylistic/eslint-stylistic#829](eslint-stylistic/eslint-stylistic#829) [eslint-stylistic/eslint-stylistic#867](eslint-stylistic/eslint-stylistic#867) [eslint-stylistic/eslint-stylistic#796](eslint-stylistic/eslint-stylistic#796) [eslint-stylistic/eslint-stylistic#884](eslint-stylistic/eslint-stylistic#884) [eslint-stylistic/eslint-stylistic#863](eslint-stylistic/eslint-stylistic#863) [eslint-stylistic/eslint-stylistic#876](eslint-stylistic/eslint-stylistic#876) [eslint-stylistic/eslint-stylistic#873](eslint-stylistic/eslint-stylistic#873) [eslint-stylistic/eslint-stylistic#862](eslint-stylistic/eslint-stylistic#862) [eslint-stylistic/eslint-stylistic#883](eslint-stylistic/eslint-stylistic#883) [eslint-stylistic/eslint-stylistic#861](eslint-stylistic/eslint-stylistic#861) [#905](https://github.com/argocd-diff-action/argocd-diff-action/issues/905) [#907](https://github.com/argocd-diff-action/argocd-diff-action/issues/907) [#900](https://github.com/argocd-diff-action/argocd-diff-action/issues/900) [#903](https://github.com/argocd-diff-action/argocd-diff-action/issues/903) [#887](https://github.com/argocd-diff-action/argocd-diff-action/issues/887) [#897](https://github.com/argocd-diff-action/argocd-diff-action/issues/897) [#891](https://github.com/argocd-diff-action/argocd-diff-action/issues/891) [#886](https://github.com/argocd-diff-action/argocd-diff-action/issues/886) [#867](https://github.com/argocd-diff-action/argocd-diff-action/issues/867) [#884](https://github.com/argocd-diff-action/argocd-diff-action/issues/884) [#796](https://github.com/argocd-diff-action/argocd-diff-action/issues/796) [#863](https://github.com/argocd-diff-action/argocd-diff-action/issues/863) [#876](https://github.com/argocd-diff-action/argocd-diff-action/issues/876) [#873](https://github.com/argocd-diff-action/argocd-diff-action/issues/873) [#862](https://github.com/argocd-diff-action/argocd-diff-action/issues/862) [#829](https://github.com/argocd-diff-action/argocd-diff-action/issues/829) [#883](https://github.com/argocd-diff-action/argocd-diff-action/issues/883) [#908](https://github.com/argocd-diff-action/argocd-diff-action/issues/908) [#900](https://github.com/argocd-diff-action/argocd-diff-action/issues/900) [#888](https://github.com/argocd-diff-action/argocd-diff-action/issues/888) [#903](https://github.com/argocd-diff-action/argocd-diff-action/issues/903) [#897](https://github.com/argocd-diff-action/argocd-diff-action/issues/897) [#891](https://github.com/argocd-diff-action/argocd-diff-action/issues/891) [#887](https://github.com/argocd-diff-action/argocd-diff-action/issues/887) [#886](https://github.com/argocd-diff-action/argocd-diff-action/issues/886)
* **deps-dev:** bump the npm-development group with 6 updates ([#162](#162)) ([08d72b5](08d72b5)), closes [#19828](https://github.com/argocd-diff-action/argocd-diff-action/issues/19828) [#19882](https://github.com/argocd-diff-action/argocd-diff-action/issues/19882) [#19971](https://github.com/argocd-diff-action/argocd-diff-action/issues/19971) [#19877](https://github.com/argocd-diff-action/argocd-diff-action/issues/19877) [#19965](https://github.com/argocd-diff-action/argocd-diff-action/issues/19965) [#19932](https://github.com/argocd-diff-action/argocd-diff-action/issues/19932) [#19944](https://github.com/argocd-diff-action/argocd-diff-action/issues/19944) [#19937](https://github.com/argocd-diff-action/argocd-diff-action/issues/19937) [#19970](https://github.com/argocd-diff-action/argocd-diff-action/issues/19970) [#19964](https://github.com/argocd-diff-action/argocd-diff-action/issues/19964) [#19953](https://github.com/argocd-diff-action/argocd-diff-action/issues/19953) [#19960](https://github.com/argocd-diff-action/argocd-diff-action/issues/19960) [#19949](https://github.com/argocd-diff-action/argocd-diff-action/issues/19949) [#19919](https://github.com/argocd-diff-action/argocd-diff-action/issues/19919) [#19948](https://github.com/argocd-diff-action/argocd-diff-action/issues/19948) [#19943](https://github.com/argocd-diff-action/argocd-diff-action/issues/19943) [#19971](https://github.com/argocd-diff-action/argocd-diff-action/issues/19971) [#19877](https://github.com/argocd-diff-action/argocd-diff-action/issues/19877) [#19970](https://github.com/argocd-diff-action/argocd-diff-action/issues/19970) [#19965](https://github.com/argocd-diff-action/argocd-diff-action/issues/19965) [#19964](https://github.com/argocd-diff-action/argocd-diff-action/issues/19964) [#19953](https://github.com/argocd-diff-action/argocd-diff-action/issues/19953) [#19960](https://github.com/argocd-diff-action/argocd-diff-action/issues/19960) [#19932](https://github.com/argocd-diff-action/argocd-diff-action/issues/19932) [#19949](https://github.com/argocd-diff-action/argocd-diff-action/issues/19949) [#19828](https://github.com/argocd-diff-action/argocd-diff-action/issues/19828) [#19919](https://github.com/argocd-diff-action/argocd-diff-action/issues/19919) [#19882](https://github.com/argocd-diff-action/argocd-diff-action/issues/19882) [#19948](https://github.com/argocd-diff-action/argocd-diff-action/issues/19948) [#19944](https://github.com/argocd-diff-action/argocd-diff-action/issues/19944) [#19943](https://github.com/argocd-diff-action/argocd-diff-action/issues/19943) [#19937](https://github.com/argocd-diff-action/argocd-diff-action/issues/19937) [#15702](https://github.com/argocd-diff-action/argocd-diff-action/issues/15702) [#19828](https://github.com/argocd-diff-action/argocd-diff-action/issues/19828) [#19882](https://github.com/argocd-diff-action/argocd-diff-action/issues/19882) [#19971](https://github.com/argocd-diff-action/argocd-diff-action/issues/19971) [#19877](https://github.com/argocd-diff-action/argocd-diff-action/issues/19877) [#19965](https://github.com/argocd-diff-action/argocd-diff-action/issues/19965) [#19932](https://github.com/argocd-diff-action/argocd-diff-action/issues/19932) [#19944](https://github.com/argocd-diff-action/argocd-diff-action/issues/19944) [#19937](https://github.com/argocd-diff-action/argocd-diff-action/issues/19937) [#19970](https://github.com/argocd-diff-action/argocd-diff-action/issues/19970) [#19964](https://github.com/argocd-diff-action/argocd-diff-action/issues/19964) [#19953](https://github.com/argocd-diff-action/argocd-diff-action/issues/19953) [#19960](https://github.com/argocd-diff-action/argocd-diff-action/issues/19960) [#19949](https://github.com/argocd-diff-action/argocd-diff-action/issues/19949) [#19919](https://github.com/argocd-diff-action/argocd-diff-action/issues/19919) [#19948](https://github.com/argocd-diff-action/argocd-diff-action/issues/19948) [#19943](https://github.com/argocd-diff-action/argocd-diff-action/issues/19943) [#19971](https://github.com/argocd-diff-action/argocd-diff-action/issues/19971) [#19877](https://github.com/argocd-diff-action/argocd-diff-action/issues/19877) [#19970](https://github.com/argocd-diff-action/argocd-diff-action/issues/19970) [#19965](https://github.com/argocd-diff-action/argocd-diff-action/issues/19965) [#19964](https://github.com/argocd-diff-action/argocd-diff-action/issues/19964) [#19953](https://github.com/argocd-diff-action/argocd-diff-action/issues/19953) [#19960](https://github.com/argocd-diff-action/argocd-diff-action/issues/19960) [#19932](https://github.com/argocd-diff-action/argocd-diff-action/issues/19932) [#19949](https://github.com/argocd-diff-action/argocd-diff-action/issues/19949) [#19828](https://github.com/argocd-diff-action/argocd-diff-action/issues/19828) [#19919](https://github.com/argocd-diff-action/argocd-diff-action/issues/19919) [#19882](https://github.com/argocd-diff-action/argocd-diff-action/issues/19882) [#19948](https://github.com/argocd-diff-action/argocd-diff-action/issues/19948) [#19944](https://github.com/argocd-diff-action/argocd-diff-action/issues/19944) [#19943](https://github.com/argocd-diff-action/argocd-diff-action/issues/19943) [#19937](https://github.com/argocd-diff-action/argocd-diff-action/issues/19937) [#19971](https://github.com/argocd-diff-action/argocd-diff-action/issues/19971) [#19877](https://github.com/argocd-diff-action/argocd-diff-action/issues/19877) [#19970](https://github.com/argocd-diff-action/argocd-diff-action/issues/19970) [#19965](https://github.com/argocd-diff-action/argocd-diff-action/issues/19965) [#19964](https://github.com/argocd-diff-action/argocd-diff-action/issues/19964) [#19953](https://github.com/argocd-diff-action/argocd-diff-action/issues/19953) [#19960](https://github.com/argocd-diff-action/argocd-diff-action/issues/19960) [#15702](https://github.com/argocd-diff-action/argocd-diff-action/issues/15702) [#15702](https://github.com/argocd-diff-action/argocd-diff-action/issues/15702) [#11391](https://github.com/argocd-diff-action/argocd-diff-action/issues/11391) [#11397](https://github.com/argocd-diff-action/argocd-diff-action/issues/11397) [#11351](https://github.com/argocd-diff-action/argocd-diff-action/issues/11351) [#11412](https://github.com/argocd-diff-action/argocd-diff-action/issues/11412) [#11361](https://github.com/argocd-diff-action/argocd-diff-action/issues/11361) [#11329](https://github.com/argocd-diff-action/argocd-diff-action/issues/11329) [#11361](https://github.com/argocd-diff-action/argocd-diff-action/issues/11361) [#11412](https://github.com/argocd-diff-action/argocd-diff-action/issues/11412) [#11](#11) [#11412](https://github.com/argocd-diff-action/argocd-diff-action/issues/11412)
* **deps:** bump actions/checkout from 4 to 5 ([#170](#170)) ([a7d32d7](a7d32d7)), closes [actions/checkout#2226](actions/checkout#2226) [actions/checkout#2238](actions/checkout#2238) [actions/checkout#1971](actions/checkout#1971) [actions/checkout#1977](actions/checkout#1977) [actions/checkout#2043](actions/checkout#2043) [actions/checkout#2044](actions/checkout#2044) [actions/checkout#2194](actions/checkout#2194) [actions/checkout#2224](actions/checkout#2224) [actions/checkout#2236](actions/checkout#2236) [actions/checkout#2237](actions/checkout#2237) [actions/checkout#1971](actions/checkout#1971) [actions/checkout#1977](actions/checkout#1977) [actions/checkout#2043](actions/checkout#2043) [actions/checkout#2194](actions/checkout#2194) [actions/checkout#2236](actions/checkout#2236) [actions/checkout#1941](actions/checkout#1941) [actions/checkout#1946](actions/checkout#1946) [actions/checkout#1924](actions/checkout#1924) [actions/checkout#1919](actions/checkout#1919) [actions/checkout#2226](actions/checkout#2226) [actions/checkout#1971](actions/checkout#1971) [actions/checkout#1977](actions/checkout#1977) [actions/checkout#2043](actions/checkout#2043) [actions/checkout#2044](actions/checkout#2044) [actions/checkout#2194](actions/checkout#2194) [actions/checkout#2224](actions/checkout#2224) [actions/checkout#2236](actions/checkout#2236) [actions/checkout#1941](actions/checkout#1941) [actions/checkout#1946](actions/checkout#1946) [actions/checkout#1924](actions/checkout#1924) [actions/checkout#1180](actions/checkout#1180) [actions/checkout#1777](actions/checkout#1777) [actions/checkout#1872](actions/checkout#1872) [actions/checkout#1739](actions/checkout#1739) [actions/checkout#1697](actions/checkout#1697) [actions/checkout#1774](actions/checkout#1774) [actions/checkout#1776](actions/checkout#1776) [actions/checkout#1732](actions/checkout#1732) [actions/checkout#1703](actions/checkout#1703) [actions/checkout#1694](actions/checkout#1694) [actions/checkout#1696](actions/checkout#1696) [actions/checkout#1695](actions/checkout#1695) [actions/checkout#1707](actions/checkout#1707) [actions/checkout#1692](actions/checkout#1692) [actions/checkout#1688](actions/checkout#1688) [actions/checkout#1693](actions/checkout#1693) [actions/checkout#1643](actions/checkout#1643) [#2238](https://github.com/argocd-diff-action/argocd-diff-action/issues/2238) [#2226](https://github.com/argocd-diff-action/argocd-diff-action/issues/2226)
* **deps:** bump amannn/action-semantic-pull-request from 5 to 6 ([#169](#169)) ([56cfcc6](56cfcc6)), closes [#287](https://github.com/argocd-diff-action/argocd-diff-action/issues/287) [#287](https://github.com/argocd-diff-action/argocd-diff-action/issues/287) [#269](https://github.com/argocd-diff-action/argocd-diff-action/issues/269) [#262](https://github.com/argocd-diff-action/argocd-diff-action/issues/262) [#263](https://github.com/argocd-diff-action/argocd-diff-action/issues/263) [#261](https://github.com/argocd-diff-action/argocd-diff-action/issues/261) [#240](https://github.com/argocd-diff-action/argocd-diff-action/issues/240) [#229](https://github.com/argocd-diff-action/argocd-diff-action/issues/229) [#226](https://github.com/argocd-diff-action/argocd-diff-action/issues/226) [#208](https://github.com/argocd-diff-action/argocd-diff-action/issues/208) [#207](https://github.com/argocd-diff-action/argocd-diff-action/issues/207) [#205](https://github.com/argocd-diff-action/argocd-diff-action/issues/205) [#205](https://github.com/argocd-diff-action/argocd-diff-action/issues/205) [#289](https://github.com/argocd-diff-action/argocd-diff-action/issues/289) [#287](https://github.com/argocd-diff-action/argocd-diff-action/issues/287) [#286](https://github.com/argocd-diff-action/argocd-diff-action/issues/286) [#231](https://github.com/argocd-diff-action/argocd-diff-action/issues/231) [#281](https://github.com/argocd-diff-action/argocd-diff-action/issues/281) [#280](https://github.com/argocd-diff-action/argocd-diff-action/issues/280) [#276](https://github.com/argocd-diff-action/argocd-diff-action/issues/276) [#272](https://github.com/argocd-diff-action/argocd-diff-action/issues/272)

[skip release]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antfu antfu antfu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

semi: semi rule doesn't support accessor property

2 participants

@9romise @antfu