Skip to content

Quick Start for Existing Users V2: Mark reader task as done when user taps on a tag #16585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2022
Merged

Quick Start for Existing Users V2: Mark reader task as done when user taps on a tag #16585

merged 3 commits into from
May 18, 2022

Conversation

ashiagr
Copy link
Contributor

@ashiagr ashiagr commented May 18, 2022 •
edited
Loading

Parent #16347

The reader task can now be marked as completed by either tapping the settings button or tapping on any topic in the discover onboarding screen.

Corresponding iOS PR: wordpress-mobile/WordPress-iOS#18590

complete_reader_task_tag_tapped.mp4

To Test

Complete reader task on interest tag tap

  1. Make sure to have no topics followed
  2. Enable Quick Start for an existing site
  3. Start the Reader task
  4. Navigate to Reader
  5. Tap on Get Started to follow topics
  6. Notice that the notice gets dismissed
  7. Tap on any topic
  8. Go back and notice that the settings icon doesn't have quick start focus point and the task is marked as complete.

Complete reader task on settings button tap

  1. Enable Quick Start for an existing site
  2. Start the Reader task
  3. Navigate to Reader
  4. Tap on the Settings button
  5. Notice that the quick start notice gets dismissed
  6. Notice that the quick start focus point on the settings button gets hidden
  7. Go back and notice that the task is marked as completed

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ashiagr ashiagr added this to the 19.9 ❄️ milestone May 18, 2022
@ashiagr ashiagr requested a review from AjeshRPai May 18, 2022 09:46
@ashiagr ashiagr self-assigned this May 18, 2022
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 18, 2022 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@ashiagr ashiagr mentioned this pull request May 18, 2022
Open
23 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 18, 2022 •
edited
Loading

You can test the changes on this Pull Request by downloading the APKs:

AjeshRPai
AjeshRPai approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@AjeshRPai AjeshRPai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked at the code changes and tested it as per the instructions. Everything looks good to me. 👍 🙌

I have left a Nitpick for you to address, As this is non blocking, Am approving the PR. Feel free to merge once you have gone through it. 👍🏼 .

@ashiagr ashiagr merged commit d7e26e3 into release/19.9 May 18, 2022
@ashiagr ashiagr deleted the issue/qs-mark-reader-task-done-on-tag-tapped branch May 18, 2022 14:12
@AliSoftware AliSoftware mentioned this pull request May 18, 2022
Merged
@AliSoftware
Copy link
Contributor

This fix has now been shipped as part of the 19.9-rc-2 beta 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AjeshRPai AjeshRPai AjeshRPai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashiagr ashiagr

Labels

Quick Start

Projects

None yet

Milestone

19.9

Development

Successfully merging this pull request may close these issues.

3 participants

@ashiagr @AliSoftware @AjeshRPai