Skip to content

QuickStart for Existing Users V2: Mark reader task as done when user taps on a tag #18590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

QuickStart for Existing Users V2: Mark reader task as done when user taps on a tag #18590

merged 1 commit into from
May 12, 2022

Conversation

hassaanelgarem
Copy link
Contributor

Closes #18565

Description

The reader tour can now be marked as completed by either tapping the settings button or tapping on any topic in the discover onboarding screen

Simulator.Screen.Recording.-.iPhone.13.Pro.-.2022-05-12.at.16.54.38.mp4

Testing Instructions

New way to complete the tour

  1. Make sure to have no topics followed
  2. Enable Quick Start for an existing site
  3. Start the Reader tour
  4. Navigate to Reader
  5. Tap on any topic
  6. Make sure that the notice gets dismissed
  7. Make sure that the waypoint on the Settings button gets hidden
  8. Go back and make sure that the tour is marked as completed

Regression

  1. Enable Quick Start for an existing site
  2. Start the Reader tour
  3. Navigate to Reader
  4. Tap on the Settings button
  5. Dismiss the settings modal
  6. Make sure that the notice gets dismissed
  7. Make sure that the waypoint on the settings button gets hidden
  8. Go back and make sure that the tour is marked as completed

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaanelgarem hassaanelgarem added this to the 19.9 milestone May 12, 2022
@hassaanelgarem hassaanelgarem self-assigned this May 12, 2022
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

momo-ozawa
momo-ozawa approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hassaanelgarem hassaanelgarem enabled auto-merge May 12, 2022 15:56
@hassaanelgarem hassaanelgarem merged commit 6430e00 into trunk May 12, 2022
@hassaanelgarem hassaanelgarem deleted the issue/18565-qs-modify-reader-tour branch May 12, 2022 16:12
@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18590-3c76b21 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18590-3c76b21 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@ashiagr ashiagr mentioned this pull request May 18, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroalonso leandroalonso Awaiting requested review from leandroalonso

1 more reviewer

@momo-ozawa momo-ozawa momo-ozawa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hassaanelgarem hassaanelgarem

Labels

[Type] Task

Projects

None yet

Milestone

19.9

Development

Successfully merging this pull request may close these issues.

QuickStart for Existing Users V2: Mark reader task as done when user taps on a tag

3 participants

@hassaanelgarem @wpmobilebot @momo-ozawa