Added dismissAfterConfirm flag to FullScreenDialogFragment #10414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8002
Background
The
dismissAfterConfirm
flag will determine if the dialog will be dismissed after the confirm action is clicked. Its default behavior is to dismiss after confirm since the existing implementations utilize this.This change is being made because the username changer will need to show a confirmation & progress dialog and the result of the associated operations will determine if the dialog should be dismissed or not.
Main Changes
The builder now has a parameter for the flag, and this is how the functionality is initiated.
Testing
Use the same methods described in the WP Android block of the abstract username fragment PR description to access the suggestions screen easily.
Simply modify the builder that's used to launch the dialog in the SignUpEpilogueFragment with the
dismissAfterConfirm
flag similar to the example above.The result of this will be that clicking the Save action will do nothing.
Notice in the example below that the ripple effect signifying the click is shown on the Save action but no dismissal occurs.
Left - Default behaviour. Right - Dismiss disabled.
( Sorry for the differences in screen size. Utilized two different devices when testing 😅)
Update release notes:
RELEASE-NOTES.txt
.