-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fixes #8002: Add ability to change username #10497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This flag will determine if dialog will be dismissed after confirm is clicked. It's default behavior is to dismiss after confirm since the existing implementations utilize this.
…_fix Added dismissAfterConfirm flag to FullScreenDialogFragment
…ality can be shared. The class now has the common functionality that will be needed in the sign-up and the account settings flow. The behaviour that differs with the header & analytics will be implemented in the respective classes that extend it.
…d Injector method since it makes it easier to test. The FragmentInjector can be replaced during tests. The older method requires modification to the TestComponents/TestModules etc. Also corrected how injections were taking place by moving injection to the subtype instead of the base type since the best practice is to inject subtypes.
Verifies that the suggestions functionality is still intact even though the implementation has been modified. Created an environment where the fragment could be tested in isolation utilizing Mockito,Dagger's Android Injection and a fragment container.
…gment_abstract UsernameChangerFullScreenDialogFragment made abstract for extensibility
…een. - Create the new fragment with the functionality specific to the Settings behaviour. - The Account Settings username component now ties into the feature and gets updated once the username has been changed. - Updated FluxC hash to utilize the changes related to this PR from the username changer feature branch. - Added the fragment to the ApplicationModule and made a minor typo fix.
…t each time username changer fragment is being opened.
…cessary getters for the fields that needed to be exposed.
…asses extending need to have different implementations of it.
This reverts commit 15e56ff.
This reverts commit 8817437.
…anger_functionality Implemented change username functionality in the Account Settings
…s://github.com/wordpress-mobile/WordPress-Android into issue/8002-change-username
You can test the changes on this Pull Request by downloading the APK here. |
✅ Feature works as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Fixes #8002: Add ability to change username
To test:
Note: this is the merge of the feature branch. Code and feature in this branch was already reviewed and tested in:
There was one remaining issue and it was fixed in FluxC via wordpress-mobile/WordPress-FluxC-Android#1378 - This PR targets a recent FluxC beta (1.4.0-beta-1) including that fix.
cc @jd-alexander @malinajirka
Update release notes:
RELEASE-NOTES.txt
if necessary. Updated in 8827832