Skip to content

feat: print a deprecation warning if suite or test uses object as the third argument #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheremet-va merged 6 commits into from
Dec 5, 2024
Merged

feat: print a deprecation warning if suite or test uses object as the third argument #7031

sheremet-va merged 6 commits into from
Dec 5, 2024

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Dec 5, 2024

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@netlify
Copy link

netlify bot commented Dec 5, 2024

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 9fc2184
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6751c6ab6f60380007e6b5a7
😎 Deploy Preview https://deploy-preview-7031--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 5, 2024

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit af12c88
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6751c7116ee7040008d6bf32
😎 Deploy Preview https://deploy-preview-7031--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 37178eb
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6751d2581e5f240008a86b30
😎 Deploy Preview https://deploy-preview-7031--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va merged commit 407f10e into vitest-dev:main Dec 5, 2024
17 checks passed
@sheremet-va sheremet-va deleted the feat/warn-deprecated branch December 5, 2024 16:19
renovate bot added a commit to mmkal/eslint-plugin-mmkal that referenced this pull request Jan 16, 2025
@renovate
chore(deps): update dependency vitest to v3
62d2bd8 
##### [v3.0.0](https://github.com/vitest-dev/vitest/releases/tag/v3.0.0)

#####    🚨 Breaking Changes

-   `spy.mockReset` changes  -  by [@Lordfirespeed](https://github.com/Lordfirespeed) in vitest-dev/vitest#6426 [<samp>(db7a8)</samp>](vitest-dev/vitest@db7a8888)
-   Pass down context to test hooks  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7034 [<samp>(82c2e)</samp>](vitest-dev/vitest@82c2e244)
-   Support Vite 6  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#7026 [<samp>(7abe8)</samp>](vitest-dev/vitest@7abe854c)
-   **coverage**: Always exclude test files  -  by [@AriPerkkio](https://github.com/AriPerkkio) in vitest-dev/vitest#7254 [<samp>(b5268)</samp>](vitest-dev/vitest@b5268965)
-   **deps**: Update fake-timers to v14.0.0  -  by [@xxzefgh](https://github.com/xxzefgh) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#7097 [<samp>(c98b4)</samp>](vitest-dev/vitest@c98b4b1c)
-   **expect**: Check more properties for error equality  -  by [@hi-ogawa](https://github.com/hi-ogawa) and [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#5876 [<samp>(10023)</samp>](vitest-dev/vitest@100230e9)
-   **runner**: Support `describe(..., { shuffle: boolean })` and inherit from parent suite  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6670 [<samp>(aa1da)</samp>](vitest-dev/vitest@aa1dac3d)
-   **snapshot**: Reset snapshot state for `retry` and `repeats`  -  by [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6817 [<samp>(e8ce9)</samp>](vitest-dev/vitest@e8ce94cf)
-   **spy**: SpyOn reuses mock if method is already spyed on  -  by [@sheremet-va](https://github.com/sheremet-va) and [@hi-ogawa](https://github.com/hi-ogawa) in vitest-dev/vitest#6464 [<samp>(b3e43)</samp>](vitest-dev/vitest@b3e43d04)
-   **vitest**: Don't expose default toFake config  -  by [@sheremet-va](https://github.com/sheremet-va) in vitest-dev/vitest#6288 [<samp>(e3144)</samp>](vitest-dev/vitest@e3144fd8)

#####    🚀 Features

-   Support inline `diff` options and support `printBasicPrototype`  -  by [@hi-ogawa](