You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should we update toThrowError(new Error(...)) usage too? (I think so)
should we break snapshot too? (for now, new error formatter is applied only when diffing and this looks fine)
docs
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
Tests
Run the tests with pnpm test:ci.
Documentation
If you introduce new functionality, document it. You can run documentation with pnpm run docs command.
Changesets
Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
Description
toEqual/toStrictEqualdoes not check custom Error properties #5244NodeJs PR for a reference
todo
causediffit can fail due to chai's error message generationMaximum call stack size exceededwhen assertion fails with cyclic references ofError.causechaijs/chai#1645 Fixed!toThrowError(new Error(...))usage too? (I think so)Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.