Fix cli tests and florestad panic messages #272
                
     Merged
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
As with #271,
floresta-clitests can fail sometimes due to port conflicts. This should fix it.0)Finally we change
RpcImpl::createin order to fix the error:When
start_httppanics (e.g. when addr is already in use), its own runtime is dropped and we see this error, which hides the error that originated the panic. This is fixed by using our tokio runtime instead:For instance, if you input
--rpc-address already_in_useto florestad, you will now see a panic message with "Address already in use", but previously (not using our current tokio runtime) you'd see "Cannot drop a runtime...".