Fix electrum tests #271
Merged
Fix electrum tests #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since each test previously used a randomly chosen port within the range 18443–19442, along with `port + 1`, tests would occasionally fail with an "Address already in use" error due to port conflicts. The port selection is now set to `0`, allowing the OS to automatically assign an available port. This change should eliminate this error.
3b9b241 to
b8f080f
Compare
|
plus nitpick from README |
|
Nice! This was annoying me ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed sometimes the
floresta-electrumtests don't pass (e.g. like in my previous PR checks).Since each test previously used a randomly chosen port within the range 18443 - 19442, along with
port + 1, tests would occasionally fail with an "Address already in use" error due to port conflicts.The port selection is now set to
0, allowing the OS to automatically assign an available port. This change should eliminate this error.