Updated German holiday translations in DE.po #2392
Conversation
Summary by CodeRabbit
WalkthroughThis pull request updates the German localization file by modifying the English message identifiers for various holiday names. The changes primarily involve revising the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
holidays/locale/de/LC_MESSAGES/DE.po(1 hunks)
🔇 Additional comments (3)
holidays/locale/de/LC_MESSAGES/DE.po (3)
42-43: Good update to Labor Day translationThe change from "Erster Mai" to "Tag der Arbeit" is correct and more accurate for the German Labor Day holiday.
46-47: Good update to Ascension Day translationThe change from "Christi Himmelfahrt" to "Himmelfahrtstag" follows the PR objectives. Both terms are used in German, though "Christi Himmelfahrt" is more common. Either is acceptable.
30-117: Overall improvements to message identifiersThe changes consistently update German msgids to their English equivalents, which is good practice for internationalization. This makes the code more maintainable for non-German speakers while preserving accurate German translations.
| msgid "First Day of Christmas" | ||
| msgstr "Erste Weihnachtstag" |
There was a problem hiding this comment.
Fix grammatical error in German translation
There's a grammatical error in the German translation for Christmas Day. "Erste Weihnachtstag" should be "Erster Weihnachtstag" because "Weihnachtstag" is masculine.
msgid "First Day of Christmas"
-msgstr "Erste Weihnachtstag"
+msgstr "Erster Weihnachtstag"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| msgid "First Day of Christmas" | |
| msgstr "Erste Weihnachtstag" | |
| msgid "First Day of Christmas" | |
| msgstr "Erster Weihnachtstag" |
| msgid "75th anniversary of the East German uprising of 1953" | ||
| msgstr "75. Jahrestag des Volksaufstands in der DDR 1953" |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Add period for consistency in anniversary msgid
The msgid is missing a period at the end, unlike the similar anniversary entries above it.
-msgid "75th anniversary of the East German uprising of 1953"
+msgid "75th anniversary of the East German uprising of 1953."
msgstr "75. Jahrestag des Volksaufstands in der DDR 1953"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| msgid "75th anniversary of the East German uprising of 1953" | |
| msgstr "75. Jahrestag des Volksaufstands in der DDR 1953" | |
| msgid "75th anniversary of the East German uprising of 1953." | |
| msgstr "75. Jahrestag des Volksaufstands in der DDR 1953" |
| msgid " All Saints' Day" | ||
| msgstr "Allerheiligen" |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Remove extra space in msgid
There's an extra space at the beginning of the msgid for All Saints' Day that should be removed.
-msgid " All Saints' Day"
+msgid "All Saints' Day"
msgstr "Allerheiligen"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| msgid " All Saints' Day" | |
| msgstr "Allerheiligen" | |
| msgid "All Saints' Day" | |
| msgstr "Allerheiligen" |
|
@0N11111, |
|
@KJhellico I guess this one can be closed? |
|
I think, yes. |
Proposed Change
This PR updates the German translations in
DE.pofor better accuracy and fixes formatting issues.Changes made:
"Erster Mai"to"Tag der Arbeit"."Christi Himmelfahrt"to"Himmelfahrtstag".msgidentries to ensure correct mapping.msgidvalues, improving the structure and consistency of the file.Type of Change
holidaysfunctionality in general)Checklist
make check, and all checks/tests are green.