Update Poland holidays: add de localization
#2346
Conversation
Summary by CodeRabbit
WalkthroughThe changes add German ("de") language support for Poland. The Changes
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🔇 Additional comments (4)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 3
🔭 Outside diff range comments (1)
holidays/locale/de/LC_MESSAGES/PL.po (1)
112-115:⚠️ Potential issueFix typo in Second Day of Christmas translation
There's a spelling error in the German translation for the Second Day of Christmas.
-msgstr "Zweister Weihnachtstag" +msgstr "Zweiter Weihnachtstag"
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
README.rst(1 hunks)holidays/countries/poland.py(1 hunks)holidays/locale/de/LC_MESSAGES/PL.po(1 hunks)tests/countries/test_poland.py(1 hunks)tests/test_l10n.py(1 hunks)
🔇 Additional comments (6)
holidays/countries/poland.py (1)
30-30: LGTM on adding German language support!The addition of "de" to the
supported_languagestuple is correctly implemented and maintains alphabetical ordering of language codes.README.rst (1)
777-777: LGTM on README update!The addition of "de" to the supported languages list for Poland is consistent with the implementation change and maintains alphabetical ordering.
holidays/locale/de/LC_MESSAGES/PL.po (2)
1-27: Metadata looks good!The gettext metadata is properly formatted with appropriate project information, creation date, and translator details.
28-107: Holiday translations look accurate!The German translations for Polish holidays are culturally appropriate and correctly formatted with helpful comments.
tests/countries/test_poland.py (1)
357-374: German language tests are well structured!The test follows the same pattern as the existing tests for other languages, which is good for consistency.
tests/test_l10n.py (1)
37-42: Well implemented test for German language fallback behavior.The added test method follows the established pattern of existing tests and properly verifies that when an unavailable language is requested but the environment language is set to German, the system correctly falls back to using German for the holiday names.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2346 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 204 204
Lines 12853 12853
Branches 1817 1817
=========================================
Hits 12853 12853 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@pyniuX, thank you for this contribution, new translation is always welcome!
Is there any established translation of Polish holidays into German, or is this your own translation?
And please take a look at few suggestions.
de localization
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
holidays/locale/de/LC_MESSAGES/PL.po(1 hunks)tests/countries/test_poland.py(1 hunks)
🔇 Additional comments (6)
holidays/locale/de/LC_MESSAGES/PL.po (6)
13-13: Comment header format looks good.The header correctly identifies this file as the German localization for Polish holidays.
22-22: Language code properly defined.The file correctly specifies German ("de") as the language being used for these translations.
29-31: New Year's Day translation looks good.The German translation "Neujahr" for "Nowy Rok" is correct.
33-35: Epiphany translation is correct."Heilige Drei Könige" is the proper German translation for the Polish "Święto Trzech Króli".
109-111: Christmas Day translation is now correct.The German translation "Erster Weihnachtstag" is the correct spelling for Christmas Day.
113-115: Second Christmas Day translation is correct."Zweiter Weihnachtstag" is the proper German term for the second day of Christmas.
|
@KJhellico, |
There's no need to discuss. |
|
|
One more question, when can I approximately expect the code to be officially available in an update? |
The upcoming release is likely on Monday or Tuesday, depending on the timezone. We currently follow a twice-a-month release schedule. |
It's around Mon, Mar 17th |
There was a problem hiding this comment.
Hi @manuel2258
Could you review it if you have time?
Thank you!
There was a problem hiding this comment.
Native German here. All translations already sound good and the to me knows ones, that we also celebrate here, use the correct names.
I chased down some Wikipedia entries and their linked German translations, and maybe some of the Polish only ones could be translated, slightly better. However, that is not strictly needed, so it is also mergeable just like this.
|
@manuel2258 thanks for verifying the 🇩🇪 translation! |
Proposed change
Added German translation of Polish holidays.
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green