Skip to content

Update Israel holidays #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Dec 15, 2023
Merged

Update Israel holidays #1557

merged 18 commits into from
Dec 15, 2023

Conversation

@arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Nov 15, 2023 •
edited
Loading

Proposed change

Resolves #1549

Update Israel holidays:

  • Add Hebrew calendar holiday name constatns
  • Add l10n support: en_US, uk
  • Update README, snapshots, tests

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've added references to all holidays information sources used in this PR
  • The code style looks good: make pre-commit command generates no changes
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)

@arkid15r
Update Israel holidays
ef5851f 
  - Add Hebrew calendar holiday name constatns
  - Add l10n support: en_US, uk
  - Update README, snapshots, tests
@arkid15r arkid15r requested a review from KJhellico as a code owner November 15, 2023 00:43
@coveralls
Copy link

coveralls commented Nov 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7224547047

  • 63 of 63 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7213991652: 0.0%
Covered Lines: 10327
Relevant Lines: 10327
💛 - Coveralls

KJhellico
KJhellico reviewed Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I offer a few corrections to Ukrainian translation, but don't insist on them. :)

@arkid15r
Copy link
Collaborator Author

I offer a few corrections to Ukrainian translation, but don't insist on them. :)

I've gladly accepted your suggestions 👍

@arkid15r
Copy link
Collaborator Author

Hi @sjspielman, could you review IL.po file?

There is also yi localization but I'm open for removing it depending on your recommendations.

Thank you!

sjspielman
sjspielman reviewed Nov 22, 2023
View reviewed changes
arkid15r
arkid15r commented Nov 23, 2023
View reviewed changes
Copy link
Collaborator Author

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for reviewing this!

@arkid15r arkid15r requested a review from sjspielman November 23, 2023 00:22
KJhellico
KJhellico reviewed Dec 1, 2023
View reviewed changes
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

19 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge December 15, 2023 16:44
@arkid15r arkid15r requested a review from KJhellico December 15, 2023 16:45
KJhellico
KJhellico approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇮🇱

@arkid15r arkid15r added this pull request to the merge queue Dec 15, 2023
Merged via the queue into vacanza:beta with commit e34ac9b Dec 15, 2023
@arkid15r arkid15r deleted the update-israel branch December 15, 2023 20:47
@arkid15r
Copy link
Collaborator Author

LGTM 🇮🇱

Yay! You've got the flags!

@arkid15r arkid15r mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

@sjspielman sjspielman Awaiting requested review from sjspielman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Localize Israel holidays

4 participants

@arkid15r @coveralls @sjspielman @KJhellico