Skip to content

account for unpublished notes #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2021
Merged

account for unpublished notes #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions _includes/proposals.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,13 @@ <h4 class="featurelist__item__title flex-grow">
<ul class="featurelist__item__status featurelist__item__tags">
{% if proposal.presented | size %}
{% for presentation in proposal.presented %}
<li class="featurelist__item__presented featurelist__item__tag">
<a href="{{ presentation.url }}" title='{{ site.data["proposals"]["last-presented-alt"] }}'>{{ presentation.date }}</a>
</li>
<li class="featurelist__item__presented featurelist__item__tag">
{%- if presentation.url -%}
<a href="{{ presentation.url }}" title='{{ site.data["proposals"]["last-presented-alt"] }}'>{{ presentation.date }}</a>
{%- else -%}
<span>{{ presentation.date }}</span>
{%- endif -%}
</li>
{% endfor %}
{% endif %}
{% if proposal.tests | size %}
Expand Down
17 changes: 14 additions & 3 deletions _sass/_featurelist.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@
}
&__tag {
display: inline-block;
font-size: 0.8rem;

a {
color: white;
display: block;
font-size: 0.8rem;
margin-top: 0.5rem;
margin-top: 0.5rem;
opacity: 1;
padding-left: 0.5rem;
padding-right: 0.5rem;
Expand All @@ -33,6 +33,17 @@
background-color: transparent;
}
}

span {
background-color: $color-dim-gray;
border: 2px solid $color-dim-gray;
Comment on lines +38 to +39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd use a darker color here; the date is important info, not just the notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a preview of how it looks in the commit message. Have you seen it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, no, i hadn't; i don't usually expand commit message descriptions. thanks, this looks great.

border-radius: 10px;
color: white;
font-weight: 550;
padding-left: 0.5rem;
padding-right: 0.5rem;
margin-top: 0.5rem;
}
}
&__status {
clear: both;
Expand Down