Skip to content

account for unpublished notes #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2021
Merged

account for unpublished notes #237

merged 1 commit into from
Jan 6, 2021

Conversation

DerekNonGeneric
Copy link
Contributor

@DerekNonGeneric DerekNonGeneric commented Jan 2, 2021 •
edited
Loading

Modified info crawler algorithm presenceObject.url to be optional to account for notes that have yet to be published (non-link emoji). Once the data structure is serialized to YAML, the field will not be present in the data structure.

@DerekNonGeneric DerekNonGeneric marked this pull request as draft January 2, 2021 22:33
@DerekNonGeneric DerekNonGeneric force-pushed the fix/unlinked-month-years branch 3 times, most recently from 63cefe7 to 668f25f Compare January 2, 2021 23:52
@DerekNonGeneric DerekNonGeneric marked this pull request as ready for review January 3, 2021 00:08
@DerekNonGeneric DerekNonGeneric mentioned this pull request Jan 3, 2021
Closed
ljharb
ljharb reviewed Jan 3, 2021
View reviewed changes
@DerekNonGeneric DerekNonGeneric marked this pull request as draft January 3, 2021 04:54
@DerekNonGeneric DerekNonGeneric force-pushed the fix/unlinked-month-years branch 5 times, most recently from c4f09c4 to b888216 Compare January 5, 2021 01:30
@DerekNonGeneric DerekNonGeneric force-pushed the fix/unlinked-month-years branch from b888216 to cecb444 Compare January 5, 2021 02:31
@DerekNonGeneric DerekNonGeneric marked this pull request as ready for review January 5, 2021 02:33
ljharb
ljharb approved these changes Jan 5, 2021
View reviewed changes
_sass/_featurelist.scss
Comment on lines +38 to +39
background-color: $color-dim-gray;
border: 2px solid $color-dim-gray;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd use a darker color here; the date is important info, not just the notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a preview of how it looks in the commit message. Have you seen it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, no, i hadn't; i don't usually expand commit message descriptions. thanks, this looks great.

chicoxyzzy
chicoxyzzy approved these changes Jan 6, 2021
View reviewed changes
Copy link
Member

@chicoxyzzy chicoxyzzy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codehag codehag merged commit 00f6b01 into tc39:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

+1 more reviewer

@chicoxyzzy chicoxyzzy chicoxyzzy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DerekNonGeneric @ljharb @chicoxyzzy @codehag