-
Notifications
You must be signed in to change notification settings - Fork 64
🏗️✨ introduce ESLint #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗️✨ introduce ESLint #213
Conversation
c82e446
to
4bebaee
Compare
I should have stepped in earlier. I am a bit concerned that this is bringing so many conventions which were not a part of this codebase before. We mostly do not need this work. If you want to add eslint, can you add it as the default, and we iterate from there? Additionally, the real benefit here will be a |
4bebaee
to
aebca30
Compare
Sorry, I must've misinterpreted what you said. If you were interested in expanding the site w/ localization and things, I was thinking big. That requires quite a bit of engineering work to get done and I was trying to save you the effort of all this config. |
9e961b8
to
d2fcc39
Compare
2bc30b6
to
ce2ae15
Compare
@ljharb, you can disregard the second review — all of your concerns have been addressed. This is pretty much as bare-bones as it gets. I don't think simplifying any further would be advantageos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think you've resolved all my concerns, and I really appreciate your patience and persistence working through them.
Remaining comments would be nonblockers had I the place to block here; i'll leave it to the repo maintainers to review further.
9189ab2
to
25b17bd
Compare
9110a57
to
eea7264
Compare
3630756
to
841deb1
Compare
841deb1
to
d30a919
Compare
d30a919
to
032a568
Compare
Please refer to the second take on this PR that is currently-open instead. It reverts some of the early decisions we made:
We actually do want to have a Another thing that I did not address in this PR or the new one was creating a GitHub Action. I will have to followup w/ @codehag on that since I don't understand the reasoning behind it since Travis is already in use. Thanks so much for the tips though. I'm very pleased w/ the simplicity of the solution that resulted and welcome further scrutiny. |
(linking to #214) |
Travis is better since it is what we use -- I was saying actions because I have that on another project and forgot that we were using travis here. |
To lint a lot of formats, this PR introduces ESLint. Opening this PR early (and as a draft) in hopes to solicit feedback.
No plans on making any of the corrections until it seems like these rules sound good to adopt for now.
Impossible to be unopinionated, but didn't adopt some of the larger well-known presets, so things are likely missing from this.
/cc @ljharb @codehag