Skip to content

Conversation

DerekNonGeneric
Copy link
Contributor

To lint a lot of formats, this PR introduces ESLint. Opening this PR early (and as a draft) in hopes to solicit feedback.

No plans on making any of the corrections until it seems like these rules sound good to adopt for now.

Impossible to be unopinionated, but didn't adopt some of the larger well-known presets, so things are likely missing from this.

/cc @ljharb @codehag

@DerekNonGeneric DerekNonGeneric force-pushed the feat/add-eslint branch 2 times, most recently from c82e446 to 4bebaee Compare October 12, 2020 15:31
@codehag
Copy link
Collaborator

codehag commented Oct 14, 2020

I should have stepped in earlier. I am a bit concerned that this is bringing so many conventions which were not a part of this codebase before. We mostly do not need this work. If you want to add eslint, can you add it as the default, and we iterate from there?

Additionally, the real benefit here will be a github action travis config.

@DerekNonGeneric
Copy link
Contributor Author

I am a bit concerned that this is bringing so many conventions which were not a part of this codebase before.

Sorry, I must've misinterpreted what you said. If you were interested in expanding the site w/ localization and things, I was thinking big. That requires quite a bit of engineering work to get done and I was trying to save you the effort of all this config.

@DerekNonGeneric DerekNonGeneric force-pushed the feat/add-eslint branch 5 times, most recently from 9e961b8 to d2fcc39 Compare October 14, 2020 22:22
@DerekNonGeneric DerekNonGeneric force-pushed the feat/add-eslint branch 11 times, most recently from 2bc30b6 to ce2ae15 Compare October 17, 2020 22:55
@DerekNonGeneric DerekNonGeneric marked this pull request as ready for review October 19, 2020 03:46
@DerekNonGeneric
Copy link
Contributor Author

@ljharb, you can disregard the second review — all of your concerns have been addressed.

This is pretty much as bare-bones as it gets. I don't think simplifying any further would be advantageos.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think you've resolved all my concerns, and I really appreciate your patience and persistence working through them.

Remaining comments would be nonblockers had I the place to block here; i'll leave it to the repo maintainers to review further.

@DerekNonGeneric DerekNonGeneric marked this pull request as draft October 19, 2020 22:52
@DerekNonGeneric DerekNonGeneric force-pushed the feat/add-eslint branch 2 times, most recently from 9189ab2 to 25b17bd Compare October 20, 2020 05:34
@DerekNonGeneric DerekNonGeneric marked this pull request as ready for review October 20, 2020 05:40
@DerekNonGeneric DerekNonGeneric marked this pull request as draft October 22, 2020 01:29
@DerekNonGeneric DerekNonGeneric force-pushed the feat/add-eslint branch 2 times, most recently from 3630756 to 841deb1 Compare October 22, 2020 20:31
@DerekNonGeneric DerekNonGeneric marked this pull request as ready for review October 22, 2020 20:36
@DerekNonGeneric
Copy link
Contributor Author

DerekNonGeneric commented Oct 23, 2020

Please refer to the second take on this PR that is currently-open instead.

It reverts some of the early decisions we made:

  • putting .prettierrc options in the .eslintrc
  • attempting to style-check JSON using ESLint
  • et al.

We actually do want to have a .prettierrc populated w/ this config for JSON style-checking.


Another thing that I did not address in this PR or the new one was creating a GitHub Action. I will have to followup w/ @codehag on that since I don't understand the reasoning behind it since Travis is already in use. Thanks so much for the tips though. I'm very pleased w/ the simplicity of the solution that resulted and welcome further scrutiny.

@ljharb
Copy link
Member

ljharb commented Oct 23, 2020

(linking to #214)

@codehag
Copy link
Collaborator

codehag commented Oct 26, 2020

I will have to followup w/ @codehag on that since I don't understand the reasoning behind it since Travis is already in use.

Travis is better since it is what we use -- I was saying actions because I have that on another project and forgot that we were using travis here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants