Skip to content

Conversation

DerekNonGeneric
Copy link
Contributor

@DerekNonGeneric DerekNonGeneric commented Oct 22, 2020

To verify JavaScript correctness (both code quality and code style), this PR introduces ESLint.

This is normally done at the very beginning of a project, but for some reason, it was missing.

It includes a run script for auto fixing errors and corrects all of the errors flagged by it.

@DerekNonGeneric DerekNonGeneric force-pushed the feat/intro-eslint branch 2 times, most recently from 1411105 to 25a3b25 Compare October 26, 2020 02:00
@DerekNonGeneric DerekNonGeneric marked this pull request as draft October 26, 2020 07:48
@DerekNonGeneric DerekNonGeneric marked this pull request as ready for review October 26, 2020 10:12
@codehag
Copy link
Collaborator

codehag commented Oct 27, 2020

looks good to me

@codehag codehag merged commit d7dbeb8 into tc39:master Oct 27, 2020
DerekNonGeneric added a commit to DerekNonGeneric/tc39.github.io that referenced this pull request Nov 6, 2020
* 📦 install array of dependencies used by ESLint

* 🏗️ add minimal .eslintrc

* 🏗️ add defaults to .browserlistrc

* 🏗️ add _site to .eslintignore

* 🏗️ add Babel configs

* 🏗️ exclude babel.config.json

* 🏗️✨ update lint:js & add format:js run scripts

* 🏗️ add minimal .prettierrc

* 🔧 appease ESLint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants