-
Notifications
You must be signed in to change notification settings - Fork 21
ci: remove deploy to conda forge job #3756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ on: | |
|
|
||
| defaults: | ||
| run: | ||
| shell: bash -l {0} # required for conda env | ||
| shell: bash | ||
|
|
||
| jobs: | ||
| check_release: | ||
|
|
@@ -23,24 +23,6 @@ jobs: | |
| - run: tox -e check-release | ||
| if: github.event_name == 'release' && github.event.action == 'published' | ||
|
|
||
| build_conda: | ||
| name: Conda | ||
| needs: check_release | ||
| strategy: | ||
| matrix: | ||
| variant: | ||
| - {os: ubuntu-24.04, target: linux_64} | ||
| - {os: macos-13, target: osx_64} | ||
| - {os: macos-14, target: osx_arm64} | ||
| - {os: windows-2022, target: win_64} | ||
| - {os: ubuntu-24.04-arm, target: linux_arm64} | ||
| python-version: ["3.11", "3.12", "3.13"] | ||
| uses: ./.github/workflows/conda.yml | ||
| with: | ||
| os: ${{ matrix.variant.os }} | ||
| target: ${{ matrix.variant.target }} | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| build_sdist: | ||
| name: Build SDist | ||
| needs: check_release | ||
|
|
@@ -77,7 +59,7 @@ jobs: | |
|
|
||
| upload_pypi: | ||
| name: Deploy PyPI | ||
| needs: [build_wheels, build_sdist, build_conda] | ||
| needs: [build_wheels, build_sdist] | ||
| runs-on: ubuntu-24.04 | ||
| environment: release | ||
| permissions: | ||
|
|
@@ -92,22 +74,6 @@ jobs: | |
| pattern: 'dist*' | ||
| - uses: pypa/[email protected] | ||
|
|
||
| upload_conda: | ||
| name: Deploy Conda Forge | ||
| needs: [build_wheels, build_sdist, build_conda] | ||
| runs-on: ubuntu-24.04 | ||
| if: github.event_name == 'release' && github.event.action == 'published' | ||
|
|
||
| steps: | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| pattern: 'conda*' | ||
| - uses: conda-incubator/setup-miniconda@v3 | ||
| with: | ||
| python-version: '3.12' | ||
| - run: conda install -c conda-forge --yes anaconda-client | ||
| - run: anaconda --token ${{ secrets.ANACONDATOKEN }} upload --user scipp --label main $(find . -type f -name "*.conda") | ||
|
|
||
| manage-versions: | ||
| name: Manage Versions | ||
| needs: check_release | ||
|
|
@@ -131,7 +97,7 @@ jobs: | |
| echo "replaced=$(python docs/version.py --version=${GITHUB_REF_NAME} --action=get-replaced)" >> $GITHUB_OUTPUT | ||
|
|
||
| docs: | ||
| needs: [upload_conda, upload_pypi, manage-versions] | ||
| needs: [upload_pypi, manage-versions] | ||
| uses: ./.github/workflows/docs.yml | ||
| with: | ||
| publish: ${{ github.event_name == 'release' && github.event.action == 'published' }} | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove
build_conda?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought maybe we wanted to keep it to prevent pypi from deploying if the conda build fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which actual problems would that catch, and how many false-positive build fails would we get for every problem caught?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would catch any problem that causes the conda build to fail while the pypi build does not fail. Doesn't seem like a too exotic failure mode.
But if you think that is an unlikely scenario then we can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experience many fails are due to CI problems, not actually anything that is broken in the package. I think it was discussed elsewhere that we anyway need (periodic?) jobs that verify that conda-packaging still works. I don't think this is that purpose of a release build?