ci: remove deploy to conda forge job #3756
Conversation
|
Aha but the workflow here only deploys to our |
|
We should remove it, we only have the conda bits around in scipp to test the weekly builds. We do not need maintain a scipp channel. |
|
|
||
| upload_conda: | ||
| name: Deploy Conda Forge | ||
| needs: [build_wheels, build_sdist, build_conda] |
There was a problem hiding this comment.
I thought maybe we wanted to keep it to prevent pypi from deploying if the conda build fails?
There was a problem hiding this comment.
Which actual problems would that catch, and how many false-positive build fails would we get for every problem caught?
There was a problem hiding this comment.
It would catch any problem that causes the conda build to fail while the pypi build does not fail. Doesn't seem like a too exotic failure mode.
But if you think that is an unlikely scenario then we can remove it.
There was a problem hiding this comment.
In my experience many fails are due to CI problems, not actually anything that is broken in the package. I think it was discussed elsewhere that we anyway need (periodic?) jobs that verify that conda-packaging still works. I don't think this is that purpose of a release build?
If I understand correctly the conda-forge deployment is done automatically by the feedstock.
Then it seems reasonable we should not also deploy to conda forge in the release workflow.
Is that correct?