-
Notifications
You must be signed in to change notification settings - Fork 706
feat(risedev): add frontend-node rust #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| statement ok | ||
| create table t (v1 int not null); | ||
|
|
||
| statement ok | ||
| drop table t; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| use std::env; | ||
| use std::path::Path; | ||
| use std::process::Command; | ||
|
|
||
| use anyhow::{anyhow, Result}; | ||
|
|
||
| use super::{ExecuteContext, Task}; | ||
| use crate::FrontendConfig; | ||
|
|
||
| pub struct FrontendServiceV2 { | ||
| config: FrontendConfig, | ||
| } | ||
|
|
||
| impl FrontendServiceV2 { | ||
| pub fn new(config: FrontendConfig) -> Result<Self> { | ||
| Ok(Self { config }) | ||
| } | ||
|
|
||
| fn frontend_v2(&self) -> Result<Command> { | ||
| let prefix_bin = env::var("PREFIX_BIN")?; | ||
| Ok(Command::new(Path::new(&prefix_bin).join("frontend-v2"))) | ||
| } | ||
| } | ||
|
|
||
| impl Task for FrontendServiceV2 { | ||
| fn execute(&mut self, ctx: &mut ExecuteContext<impl std::io::Write>) -> anyhow::Result<()> { | ||
| ctx.service(self); | ||
| ctx.pb.set_message("starting..."); | ||
|
|
||
| let mut cmd = self.frontend_v2()?; | ||
|
|
||
| cmd.arg("--host") | ||
| .arg(format!("{}:{}", self.config.address, self.config.port)); | ||
|
|
||
| let provide_meta_node = self.config.provide_meta_node.as_ref().unwrap(); | ||
| match provide_meta_node.len() { | ||
| 0 => { | ||
| return Err(anyhow!( | ||
| "Cannot start node: no meta node found in this configuration." | ||
| )); | ||
| } | ||
| 1 => { | ||
| let meta_node = &provide_meta_node[0]; | ||
| cmd.arg("--meta-addr") | ||
| .arg(format!("http://{}:{}", meta_node.address, meta_node.port)); | ||
| } | ||
| other_size => { | ||
| return Err(anyhow!( | ||
| "Cannot start node: {} meta nodes found in this configuration, but only 1 is needed.", | ||
| other_size | ||
| )); | ||
| } | ||
| }; | ||
|
|
||
| if !self.config.user_managed { | ||
| ctx.run_command(ctx.tmux_run(cmd)?)?; | ||
| ctx.pb.set_message("started"); | ||
| } else { | ||
| ctx.pb.set_message("user managed"); | ||
| } | ||
|
|
||
| Ok(()) | ||
| } | ||
|
|
||
| fn id(&self) -> String { | ||
| self.config.id.clone() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking of uploading all
***-nodeinto one artifact zip...Another idea is to create an
all-in-onebinary for all our nodes. IIRC, every executable we created is ~200MB, but most debug symbols are the same...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM