Skip to content

feat(risedev): add frontend-node rust #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2022
Merged

feat(risedev): add frontend-node rust #390

merged 1 commit into from
Feb 18, 2022

Conversation

@BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Feb 17, 2022 •
edited
Loading

What's changed and what's your intention?

  • Summarize your change (mandatory)
  1. Add new frontend node in risedev. Command: ./risedev ci-v2.
  2. Add a new step in CI (with very basic sqllogictest).
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  1. Add a frontend_service_v2 in risedev codebase.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/feature Type: New feature. label Feb 17, 2022
@BowenXiao1999 BowenXiao1999 force-pushed the bw_add_FE_to_dev branch 2 times, most recently from d6ab3b6 to 6bf06b9 Compare February 17, 2022 07:54
@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited
Loading

Codecov Report

Merging #390 (a12efed) into main (53bf192) will decrease coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #390      +/-   ##
============================================
- Coverage     72.85%   72.84%   -0.01%     
  Complexity     2686     2686              
============================================
  Files           868      868              
  Lines         49156    49159       +3     
  Branches       1579     1579              
============================================
  Hits          35811    35811              
- Misses        12532    12535       +3     
  Partials        813      813
Flag Coverage Δ
java 62.34% <ø> (ø)
rust 77.30% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/utils/pgwire/src/pg_server.rs 84.90% <57.14%> (-3.10%) ⬇️
rust/utils/pgwire/src/pg_protocol.rs 81.81% <100.00%> (ø)
rust/common/src/types/ordered_float.rs 25.49% <0.00%> (-0.34%) ⬇️
rust/stream/src/executor/barrier_align.rs 78.78% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53bf192...a12efed. Read the comment docs.

@BowenXiao1999 BowenXiao1999 force-pushed the bw_add_FE_to_dev branch 5 times, most recently from 788f9a7 to 7952f06 Compare February 17, 2022 08:54
@BowenXiao1999 BowenXiao1999 changed the title feat: add frontend rust in risedev feat(risedev): add frontend rust in risedev Feb 17, 2022
@BowenXiao1999 BowenXiao1999 changed the title feat(risedev): add frontend rust in risedev feat(risedev): add frontend-node rust Feb 17, 2022
@st1page st1page requested a review from fuyufjh February 17, 2022 09:05
skyzh
skyzh reviewed Feb 17, 2022
View reviewed changes
Copy link
Contributor

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, good work!

.github/workflow-template/template.yml Outdated
Copy link
Contributor

@skyzh skyzh Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking of uploading all ***-node into one artifact zip...

Another idea is to create an all-in-one binary for all our nodes. IIRC, every executable we created is ~200MB, but most debug symbols are the same...

Copy link
Contributor Author

@BowenXiao1999 BowenXiao1999 Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BowenXiao1999 BowenXiao1999 force-pushed the bw_add_FE_to_dev branch 4 times, most recently from d589127 to 45db6c6 Compare February 18, 2022 05:54
@BowenXiao1999 BowenXiao1999 force-pushed the bw_add_FE_to_dev branch 4 times, most recently from 1f56267 to ced2644 Compare February 18, 2022 10:14
@BowenXiao1999 BowenXiao1999 enabled auto-merge (squash) February 18, 2022 10:19
@BowenXiao1999 BowenXiao1999 force-pushed the bw_add_FE_to_dev branch 2 times, most recently from dfee130 to 1ea2ae8 Compare February 18, 2022 10:43
@BowenXiao1999 BowenXiao1999 merged commit 4c2da8c into main Feb 18, 2022
@BowenXiao1999 BowenXiao1999 deleted the bw_add_FE_to_dev branch February 18, 2022 11:09
@BowenXiao1999 BowenXiao1999 linked an issue Feb 21, 2022 that may be closed by this pull request
Server(FE): Integrate new rust frontend into risedev #351
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HuaHuaY HuaHuaY Awaiting requested review from HuaHuaY

@fuyufjh fuyufjh Awaiting requested review from fuyufjh

1 more reviewer

@skyzh skyzh skyzh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type/feature Type: New feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Server(FE): Integrate new rust frontend into risedev

3 participants

@BowenXiao1999 @skyzh